From: David Rientjes <rientjes@google.com>
To: Christopher Lameter <cl@linux.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Pekka Enberg <penberg@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mm/slab: One function call less in verify_redzone_free()
Date: Sat, 6 Jul 2019 15:45:10 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1907061542480.103032@chino.kir.corp.google.com> (raw)
In-Reply-To: <0100016bc3579800-ee6cd00b-6f59-4d86-be0c-f63e2b137d18-000000@email.amazonses.com>
On Fri, 5 Jul 2019, Christopher Lameter wrote:
> On Fri, 5 Jul 2019, Markus Elfring wrote:
>
> > Avoid an extra function call by using a ternary operator instead of
> > a conditional statement for a string literal selection.
>
> Well. I thought the compiler does that on its own? And the tenary operator
> makes the code difficult to read.
>
Right, and I don't understand the changelog: yes, there's one less
function call in the source but functionally there's still a conditional;
this isn't even optimizing DEBUG builds.
next prev parent reply other threads:[~2019-07-06 22:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 14:50 [PATCH] mm/slab: One function call less in verify_redzone_free() Markus Elfring
2019-07-05 18:13 ` Christopher Lameter
2019-07-06 22:45 ` David Rientjes [this message]
2019-07-05 14:50 Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1907061542480.103032@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).