From: Thomas Gleixner <tglx@linutronix.de>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
x86@kernel.org, Michal Hocko <mhocko@suse.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Tony Luck <tony.luck@intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Oscar Salvador <osalvador@suse.de>,
Pavel Tatashin <pavel.tatashin@microsoft.com>,
Mel Gorman <mgorman@techsingularity.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Stephen Rothwell <sfr@canb.auug.org.au>, Qian Cai <cai@lca.pw>,
Barret Rhoden <brho@google.com>,
Bjorn Helgaas <bhelgaas@google.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] x86/numa: instance all parsed numa node
Date: Wed, 10 Jul 2019 13:39:00 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1907101334230.1758@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAFgQCTtK7G9NPQgHa_gJkr8WLzYqagBVLaqBY7-w+tirX-+w-g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]
On Wed, 10 Jul 2019, Pingfan Liu wrote:
> On Tue, Jul 9, 2019 at 9:34 PM Andy Lutomirski <luto@amacapital.net> wrote:
> >
> > Go for it. I’m not familiar enough with the SMP boot stuff that I would
> > be able to do it any faster than you. I’ll gladly help review it.
>
> I had sent out a patch to fix maxcpus "[PATCH] smp: force all cpu to
> boot once under maxcpus option"
>
> But for the case of nrcpus, I think things will not be so easy due to
> percpu area, and I think it may take a quite different way.
No.
It's the same problem and it's broken in the same way as maxcpus on x86. So
nr_cpus on x86 has to do:
if (nr_cpus < num_present_cpus()) {
pr_info(....);
max_cpus = nr_cpus;
nr_cpus = num_present_cpus();
}
or something like that.
Stop making extra cases which are pointlessly different. X86 boot is a
trainwreck in hardware, so no magic software can fix it.
All you can do is pray that it reaches the point where all present CPUs
have been at least minimaly initialized.
Thanks,
tglx
prev parent reply other threads:[~2019-07-10 11:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 4:15 [PATCH 1/2] x86/numa: carve node online semantics out of alloc_node_data() Pingfan Liu
2019-07-05 4:15 ` [PATCH 2/2] x86/numa: instance all parsed numa node Pingfan Liu
2019-07-07 19:44 ` Thomas Gleixner
2019-07-08 8:36 ` Pingfan Liu
2019-07-08 9:35 ` Thomas Gleixner
2019-07-08 17:53 ` Andy Lutomirski
2019-07-08 18:26 ` Thomas Gleixner
2019-07-09 4:26 ` Pingfan Liu
2019-07-09 4:16 ` Pingfan Liu
2019-07-09 6:12 ` Thomas Gleixner
2019-07-09 7:24 ` Pingfan Liu
2019-07-09 13:34 ` Andy Lutomirski
2019-07-10 8:40 ` Pingfan Liu
2019-07-10 11:39 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1907101334230.1758@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=brho@google.com \
--cc=cai@lca.pw \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=osalvador@suse.de \
--cc=pavel.tatashin@microsoft.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rppt@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=tony.luck@intel.com \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).