linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: mingo@redhat.com, bp@alien8.de, peterz@infradead.org,
	clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org,
	yamada.masahiro@socionext.com, stable@vger.kernel.org,
	Vaibhav Rustagi <vaibhavrustagi@google.com>,
	Manoj Gupta <manojgupta@google.com>,
	Alistair Delva <adelva@google.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Enrico Weigelt <info@metux.net>,
	Allison Randal <allison@lohutok.net>,
	Uros Bizjak <ubizjak@gmail.com>,
	Chao Fan <fanc.fnst@cn.fujitsu.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alexios Zavras <alexios.zavras@intel.com>
Subject: Re: [PATCH v3 1/2] x86/purgatory: do not use __builtin_memcpy and __builtin_memset
Date: Wed, 24 Jul 2019 12:33:03 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1907241231480.1972@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190723212418.36379-1-ndesaulniers@google.com>

On Tue, 23 Jul 2019, Nick Desaulniers wrote:
> Instead, reuse an implementation from arch/x86/boot/compressed/string.c
> if we define warn as a symbol. Also, Clang may lower memcmp's that
> compare against 0 to bcmp's, so add a small definition, too. See also:
> commit 5f074f3e192f ("lib/string.c: implement a basic bcmp")
> 
> Cc: stable@vger.kernel.org
> Fixes: 8fc5b4d4121c ("purgatory: core purgatory functionality")
> Link: https://bugs.chromium.org/p/chromium/issues/detail?id=984056
> Reported-by: Vaibhav Rustagi <vaibhavrustagi@google.com>
> Debugged-by: Vaibhav Rustagi <vaibhavrustagi@google.com>
> Debugged-by: Manoj Gupta <manojgupta@google.com>
> Suggested-by: Alistair Delva <adelva@google.com>
> Signed-off-by: Vaibhav Rustagi <vaibhavrustagi@google.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

That SOB chain is weird. Is Vaibhav the author?

> +/*
> + * Clang may lower `memcmp == 0` to `bcmp == 0`.
> + */
> +int bcmp(const void *s1, const void *s2, size_t len) {
> +	return memcmp(s1, s2, len);
> +}

foo()
{
}

please.

Thanks,

	tglx

  parent reply	other threads:[~2019-07-24 10:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 21:24 [PATCH v3 1/2] x86/purgatory: do not use __builtin_memcpy and __builtin_memset Nick Desaulniers
2019-07-23 21:24 ` [PATCH v3 2/2] x86/purgatory: use CFLAGS_REMOVE rather than reset KBUILD_CFLAGS Nick Desaulniers
2019-07-24 10:35   ` Thomas Gleixner
2019-07-24 23:49   ` Vaibhav Rustagi
2019-07-23 21:24 ` [PATCH v3 0/2] Support kexec/kdump for clang built kernel Nick Desaulniers
2019-07-24 10:33 ` Thomas Gleixner [this message]
2019-07-24 20:55   ` [PATCH v3 1/2] x86/purgatory: do not use __builtin_memcpy and __builtin_memset Vaibhav Rustagi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1907241231480.1972@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=adelva@google.com \
    --cc=alexios.zavras@intel.com \
    --cc=allison@lohutok.net \
    --cc=bp@alien8.de \
    --cc=clang-built-linux@googlegroups.com \
    --cc=fanc.fnst@cn.fujitsu.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=info@metux.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manojgupta@google.com \
    --cc=mingo@redhat.com \
    --cc=ndesaulniers@google.com \
    --cc=peterz@infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=ubizjak@gmail.com \
    --cc=vaibhavrustagi@google.com \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).