From: Thomas Gleixner <tglx@linutronix.de>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: peterz@infradead.org, mingo@redhat.com, will@kernel.org,
linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH v3] seqlock: mark raw_read_seqcount and read_seqcount_retry as __always_inline
Date: Fri, 16 Aug 2019 12:16:32 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1908161209280.1873@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190726111804.18290-1-anders.roxell@linaro.org>
On Fri, 26 Jul 2019, Anders Roxell wrote:
>
> -static inline void __seqcount_init(seqcount_t *s, const char *name,
> +static __always_inline void __seqcount_init(seqcount_t *s, const char *name,
> struct lock_class_key *key)
That has nothing to do with the actual problem
> -static inline void raw_write_seqcount_begin(seqcount_t *s)
> +static __always_inline void raw_write_seqcount_begin(seqcount_t *s)
Neither this, nor these:
> -static inline void raw_write_seqcount_end(seqcount_t *s)
> +static __always_inline void raw_write_seqcount_end(seqcount_t *s)
> {
> -static inline void raw_write_seqcount_barrier(seqcount_t *s)
> +static __always_inline void raw_write_seqcount_barrier(seqcount_t *s)
The following is fine as it is used in the NMI safe time accessors which
can be used as trace clock:
> -static inline int raw_read_seqcount_latch(seqcount_t *s)
> +static __always_inline int raw_read_seqcount_latch(seqcount_t *s)
The rest is bogus...
s/inline/__always_inline/g is conveniant, but does neither match the
changelog nor does it make sense.
Thanks,
tglx
prev parent reply other threads:[~2019-08-16 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 11:18 [PATCH v3] seqlock: mark raw_read_seqcount and read_seqcount_retry as __always_inline Anders Roxell
2019-08-16 10:16 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1908161209280.1873@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=anders.roxell@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).