From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 037CFC3A5A0 for ; Mon, 19 Aug 2019 18:43:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD06022CF9 for ; Mon, 19 Aug 2019 18:43:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728229AbfHSSnO (ORCPT ); Mon, 19 Aug 2019 14:43:14 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:48422 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727769AbfHSSnO (ORCPT ); Mon, 19 Aug 2019 14:43:14 -0400 Received: from pd9ef1cb8.dip0.t-ipconnect.de ([217.239.28.184] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hzmcR-0001p5-Vz; Mon, 19 Aug 2019 20:43:04 +0200 Date: Mon, 19 Aug 2019 20:43:03 +0200 (CEST) From: Thomas Gleixner To: Sebastian Mayr cc: Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] uprobes/x86: fix detection of 32-bit user mode In-Reply-To: <2d8f1744136431b5eb0bda24ea767374d6fde4e5.camel@sam.st> Message-ID: References: <20190728152617.7308-1-me@sam.st> <2d8f1744136431b5eb0bda24ea767374d6fde4e5.camel@sam.st> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Aug 2019, Sebastian Mayr wrote: > > @@ -1056,7 +1056,7 @@ bool arch_uprobe_skip_sstep(struct arch_uprobe > > *auprobe, struct pt_regs *regs) > > unsigned long > > arch_uretprobe_hijack_return_addr(unsigned long trampoline_vaddr, > > struct pt_regs *regs) > > { > > - int rasize = sizeof_long(), nleft; > > + int rasize = sizeof_long(regs), nleft; > > unsigned long orig_ret_vaddr = 0; /* clear high bits for 32-bit > > apps */ > > > > if (copy_from_user(&orig_ret_vaddr, (void __user *)regs->sp, > > rasize)) > > Any feedback on this patch would be greatly appreciated. Sorry, fell through the cracks. Thanks for the reminder!