From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52B6EC43331 for ; Fri, 6 Sep 2019 06:59:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 349CE20842 for ; Fri, 6 Sep 2019 06:59:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403970AbfIFG7G (ORCPT ); Fri, 6 Sep 2019 02:59:06 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:48530 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391691AbfIFG7G (ORCPT ); Fri, 6 Sep 2019 02:59:06 -0400 X-IronPort-AV: E=Sophos;i="5.64,472,1559512800"; d="scan'208";a="318476281" Received: from abo-12-105-68.mrs.modulonet.fr (HELO hadrien) ([85.68.105.12]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2019 08:59:02 +0200 Date: Fri, 6 Sep 2019 08:59:02 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: Stephen Boyd , YueHaibing , kernel-janitors@vger.kernel.org, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, Andrzej Hajda , Andy Shevchenko , Bartlomiej Zolnierkiewicz , Denis Efremov , Gilles Muller , Greg Kroah-Hartman , Javier Martinez Canillas , Julia Lawall , Marek Szyprowski , Mark Brown , Masahiro Yamada , Michal Marek , Nicolas Palix , Rob Herring , Russell King Subject: Re: [PATCH -next] coccinelle: platform_get_irq: Fix parse error In-Reply-To: <7818ad20-615c-2ce9-c0d1-3f7a09bedf34@web.de> Message-ID: References: <5d71eb6f.1c69fb81.31bc8.da2d@mx.google.com> <7818ad20-615c-2ce9-c0d1-3f7a09bedf34@web.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Sep 2019, Markus Elfring wrote: > > > minus: parse error: > > > File "./scripts/coccinelle/api/platform_get_irq.cocci", line 24, column 9, charpos = 355 > > > around = '\(', > > > whole content = if ( ret \( < \| <= \) 0 ) > > > > > > In commit e56476897448 ("fpga: Remove dev_err() usage > > > after platform_get_irq()") log, I found the semantic patch, > > > it fix this issue. > > > > > > Fixes: 98051ba2b28b ("coccinelle: Add script to check for platform_get_irq() excessive prints") > > > Signed-off-by: YueHaibing > > > --- > > > > Hmm I had this earlier but someone asked me to change it. > > I proposed something also during the development for this SmPL script. > https://lkml.org/lkml/2019/7/24/274 > https://lore.kernel.org/r/c98b8f50-1adf-ea95-a91c-ec451e9fefe2@web.de/ Markus, This is not the first time you have suggested to someone to do something that was simply incorrect. Please actually test your suggestions before proposing them. > > Reviewed-by: Stephen Boyd > > Should disjunctions eventually work in the semantic patch language also together with > comparison operators? > https://github.com/coccinelle/coccinelle/issues/40 No. > Will any additional software adjustments be taken into account? No. julia