linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 2/4] x86/mce: Make 3 functions non-static
@ 2019-09-11 12:01 Tony W Wang-oc
  2019-09-16  8:13 ` Thomas Gleixner
  0 siblings, 1 reply; 6+ messages in thread
From: Tony W Wang-oc @ 2019-09-11 12:01 UTC (permalink / raw)
  To: tony.luck, Borislav Petkov (bp@alien8.de),
	tglx, mingo, hpa, x86, linux-edac, linux-kernel, yazen.ghannam,
	vishal.l.verma, qiuxu.zhuo
  Cc: David Wang, Cooper Yan(BJ-RD), Qiyuan Wang(BJ-RD), Herry Yang(BJ-RD)

These functions are declared static and cannot be used in others
.c source file. this commit removes the static attribute and adds
the declaration to the header for these functions.

Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
---
v2->v3:
 - Revert 1 unused function

 arch/x86/kernel/cpu/mce/intel.c    | 6 +++---
 arch/x86/kernel/cpu/mce/internal.h | 6 ++++++
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/mce/intel.c b/arch/x86/kernel/cpu/mce/intel.c
index 88cd959..70799a5 100644
--- a/arch/x86/kernel/cpu/mce/intel.c
+++ b/arch/x86/kernel/cpu/mce/intel.c
@@ -423,7 +423,7 @@ void cmci_disable_bank(int bank)
 	raw_spin_unlock_irqrestore(&cmci_discover_lock, flags);
 }
 
-static void intel_init_cmci(void)
+void intel_init_cmci(void)
 {
 	int banks;
 
@@ -442,7 +442,7 @@ static void intel_init_cmci(void)
 	cmci_recheck();
 }
 
-static void intel_init_lmce(void)
+void intel_init_lmce(void)
 {
 	u64 val;
 
@@ -455,7 +455,7 @@ static void intel_init_lmce(void)
 		wrmsrl(MSR_IA32_MCG_EXT_CTL, val | MCG_EXT_CTL_LMCE_EN);
 }
 
-static void intel_clear_lmce(void)
+void intel_clear_lmce(void)
 {
 	u64 val;
 
diff --git a/arch/x86/kernel/cpu/mce/internal.h b/arch/x86/kernel/cpu/mce/internal.h
index 43031db..842b273 100644
--- a/arch/x86/kernel/cpu/mce/internal.h
+++ b/arch/x86/kernel/cpu/mce/internal.h
@@ -45,11 +45,17 @@ unsigned long cmci_intel_adjust_timer(unsigned long interval);
 bool mce_intel_cmci_poll(void);
 void mce_intel_hcpu_update(unsigned long cpu);
 void cmci_disable_bank(int bank);
+void intel_init_cmci(void);
+void intel_init_lmce(void);
+void intel_clear_lmce(void);
 #else
 # define cmci_intel_adjust_timer mce_adjust_timer_default
 static inline bool mce_intel_cmci_poll(void) { return false; }
 static inline void mce_intel_hcpu_update(unsigned long cpu) { }
 static inline void cmci_disable_bank(int bank) { }
+static inline void intel_init_cmci(void) { }
+static inline void intel_init_lmce(void) { }
+static inline void intel_clear_lmce(void) { }
 #endif
 
 void mce_timer_kick(unsigned long interval);
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/4] x86/mce: Make 3 functions non-static
  2019-09-11 12:01 [PATCH v3 2/4] x86/mce: Make 3 functions non-static Tony W Wang-oc
@ 2019-09-16  8:13 ` Thomas Gleixner
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Gleixner @ 2019-09-16  8:13 UTC (permalink / raw)
  To: Tony W Wang-oc
  Cc: tony.luck, Borislav Petkov (bp@alien8.de),
	mingo, hpa, x86, linux-edac, linux-kernel, yazen.ghannam,
	vishal.l.verma, qiuxu.zhuo, David Wang, Cooper Yan(BJ-RD),
	Qiyuan Wang(BJ-RD), Herry Yang(BJ-RD)

On Wed, 11 Sep 2019, Tony W Wang-oc wrote:

> These functions are declared static and cannot be used in others
> .c source file. this commit removes the static attribute and adds
> the declaration to the header for these functions.

I'm not Cc'ed on any patches which use those functions. Please Cc the
relevant maintainers on all patches of such a patch series so contect can
be seen.

Also adding some hint to the change log which new code will use that would
be appreciated.

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3 2/4] x86/mce: Make 3 functions non-static
@ 2019-09-16 11:36 Tony W Wang-oc
  0 siblings, 0 replies; 6+ messages in thread
From: Tony W Wang-oc @ 2019-09-16 11:36 UTC (permalink / raw)
  To: tony.luck, Borislav Petkov (bp@alien8.de),
	tglx, mingo, hpa, x86, linux-edac, linux-kernel, yazen.ghannam,
	vishal.l.verma, qiuxu.zhuo
  Cc: David Wang, Cooper Yan(BJ-RD), Qiyuan Wang(BJ-RD), Herry Yang(BJ-RD)

These functions are declared static and cannot be used in others
.c source file. this commit removes the static attribute and adds
the declaration to the header for these functions.

Signed-off-by: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
---
 arch/x86/kernel/cpu/mce/intel.c    | 6 +++---
 arch/x86/kernel/cpu/mce/internal.h | 6 ++++++
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/mce/intel.c b/arch/x86/kernel/cpu/mce/intel.c
index 88cd959..70799a5 100644
--- a/arch/x86/kernel/cpu/mce/intel.c
+++ b/arch/x86/kernel/cpu/mce/intel.c
@@ -423,7 +423,7 @@ void cmci_disable_bank(int bank)
 	raw_spin_unlock_irqrestore(&cmci_discover_lock, flags);
 }
 
-static void intel_init_cmci(void)
+void intel_init_cmci(void)
 {
 	int banks;
 
@@ -442,7 +442,7 @@ static void intel_init_cmci(void)
 	cmci_recheck();
 }
 
-static void intel_init_lmce(void)
+void intel_init_lmce(void)
 {
 	u64 val;
 
@@ -455,7 +455,7 @@ static void intel_init_lmce(void)
 		wrmsrl(MSR_IA32_MCG_EXT_CTL, val | MCG_EXT_CTL_LMCE_EN);
 }
 
-static void intel_clear_lmce(void)
+void intel_clear_lmce(void)
 {
 	u64 val;
 
diff --git a/arch/x86/kernel/cpu/mce/internal.h b/arch/x86/kernel/cpu/mce/internal.h
index 43031db..842b273 100644
--- a/arch/x86/kernel/cpu/mce/internal.h
+++ b/arch/x86/kernel/cpu/mce/internal.h
@@ -45,11 +45,17 @@ unsigned long cmci_intel_adjust_timer(unsigned long interval);
 bool mce_intel_cmci_poll(void);
 void mce_intel_hcpu_update(unsigned long cpu);
 void cmci_disable_bank(int bank);
+void intel_init_cmci(void);
+void intel_init_lmce(void);
+void intel_clear_lmce(void);
 #else
 # define cmci_intel_adjust_timer mce_adjust_timer_default
 static inline bool mce_intel_cmci_poll(void) { return false; }
 static inline void mce_intel_hcpu_update(unsigned long cpu) { }
 static inline void cmci_disable_bank(int bank) { }
+static inline void intel_init_cmci(void) { }
+static inline void intel_init_lmce(void) { }
+static inline void intel_clear_lmce(void) { }
 #endif
 
 void mce_timer_kick(unsigned long interval);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/4] x86/mce: Make 3 functions non-static
@ 2019-09-16  9:56 Tony W Wang-oc
  0 siblings, 0 replies; 6+ messages in thread
From: Tony W Wang-oc @ 2019-09-16  9:56 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: tony.luck, Borislav Petkov (bp@alien8.de),
	mingo, hpa, x86, linux-edac, linux-kernel, yazen.ghannam,
	vishal.l.verma, qiuxu.zhuo, David Wang, Cooper Yan(BJ-RD),
	Qiyuan Wang(BJ-RD), Herry Yang(BJ-RD)

On Mon, Sep 16, 2019, Thomas Gleixner wrote:
>On Mon, 16 Sep 2019, Tony W Wang-oc wrote:
>
>> On Mon, Sep 16, 2019, Thomas Gleixner wrote:
>> >On Wed, 11 Sep 2019, Tony W Wang-oc wrote:
>> >
>> >> These functions are declared static and cannot be used in others
>> >> .c source file. this commit removes the static attribute and adds
>> >> the declaration to the header for these functions.
>> >
>> >I'm not Cc'ed on any patches which use those functions. Please Cc the
>> >relevant maintainers on all patches of such a patch series so contect can
>> >be seen.
>> >
>>
>> Patches 3/4, 4/4 in this patchsets are using these functions. Specifically,
>> "[PATCH v3 3/4] x86/mce: Add Zhaoxin CMCI support " in this patchsets is
>> using intel_init_cmci(), "[PATCH v3 4/4] x86/mce: Add Zhaoxin LMCE support"
>> is using intel_init_lmce() and intel_clear_lmce().
>>
>> I had sent all patches in this patchsets to your mailbox. Could you help to
>> check again? Thank you.
>
>Found them by now, but please make sure that you provide cover letter
>[PATCH vX 0/N ] and thread the patches proper so they reference the cover
>letter. git send-email does that for you.

Ok, thank you, will send this patchsets with cover letter.

Sincerely
TonyWWang-oc


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/4] x86/mce: Make 3 functions non-static
  2019-09-16  9:44 Tony W Wang-oc
@ 2019-09-16  9:50 ` Thomas Gleixner
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Gleixner @ 2019-09-16  9:50 UTC (permalink / raw)
  To: Tony W Wang-oc
  Cc: tony.luck, Borislav Petkov (bp@alien8.de),
	mingo, hpa, x86, linux-edac, linux-kernel, yazen.ghannam,
	vishal.l.verma, qiuxu.zhuo, David Wang, Cooper Yan(BJ-RD),
	Qiyuan Wang(BJ-RD), Herry Yang(BJ-RD)

On Mon, 16 Sep 2019, Tony W Wang-oc wrote:

> On Mon, Sep 16, 2019, Thomas Gleixner wrote:
> >On Wed, 11 Sep 2019, Tony W Wang-oc wrote:
> >
> >> These functions are declared static and cannot be used in others
> >> .c source file. this commit removes the static attribute and adds
> >> the declaration to the header for these functions.
> >
> >I'm not Cc'ed on any patches which use those functions. Please Cc the
> >relevant maintainers on all patches of such a patch series so contect can
> >be seen.
> >
> 
> Patches 3/4, 4/4 in this patchsets are using these functions. Specifically, 
> "[PATCH v3 3/4] x86/mce: Add Zhaoxin CMCI support " in this patchsets is
> using intel_init_cmci(), "[PATCH v3 4/4] x86/mce: Add Zhaoxin LMCE support"
> is using intel_init_lmce() and intel_clear_lmce().
> 
> I had sent all patches in this patchsets to your mailbox. Could you help to
> check again? Thank you.

Found them by now, but please make sure that you provide cover letter
[PATCH vX 0/N ] and thread the patches proper so they reference the cover
letter. git send-email does that for you.

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/4] x86/mce: Make 3 functions non-static
@ 2019-09-16  9:44 Tony W Wang-oc
  2019-09-16  9:50 ` Thomas Gleixner
  0 siblings, 1 reply; 6+ messages in thread
From: Tony W Wang-oc @ 2019-09-16  9:44 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: tony.luck, Borislav Petkov (bp@alien8.de),
	mingo, hpa, x86, linux-edac, linux-kernel, yazen.ghannam,
	vishal.l.verma, qiuxu.zhuo, David Wang, Cooper Yan(BJ-RD),
	Qiyuan Wang(BJ-RD), Herry Yang(BJ-RD)

On Mon, Sep 16, 2019, Thomas Gleixner wrote:
>On Wed, 11 Sep 2019, Tony W Wang-oc wrote:
>
>> These functions are declared static and cannot be used in others
>> .c source file. this commit removes the static attribute and adds
>> the declaration to the header for these functions.
>
>I'm not Cc'ed on any patches which use those functions. Please Cc the
>relevant maintainers on all patches of such a patch series so contect can
>be seen.
>

Patches 3/4, 4/4 in this patchsets are using these functions. Specifically, 
"[PATCH v3 3/4] x86/mce: Add Zhaoxin CMCI support " in this patchsets is
using intel_init_cmci(), "[PATCH v3 4/4] x86/mce: Add Zhaoxin LMCE support"
is using intel_init_lmce() and intel_clear_lmce().

I had sent all patches in this patchsets to your mailbox. Could you help to
check again? Thank you.

>Also adding some hint to the change log which new code will use that would
>be appreciated.

Got it, will add in next version.

Sincerely
TonyWWang-oc

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-09-16 11:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 12:01 [PATCH v3 2/4] x86/mce: Make 3 functions non-static Tony W Wang-oc
2019-09-16  8:13 ` Thomas Gleixner
2019-09-16  9:44 Tony W Wang-oc
2019-09-16  9:50 ` Thomas Gleixner
2019-09-16  9:56 Tony W Wang-oc
2019-09-16 11:36 Tony W Wang-oc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).