From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D914FCA9EC3 for ; Thu, 31 Oct 2019 06:39:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD21620862 for ; Thu, 31 Oct 2019 06:39:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726808AbfJaGjX (ORCPT ); Thu, 31 Oct 2019 02:39:23 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:43759 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726479AbfJaGjX (ORCPT ); Thu, 31 Oct 2019 02:39:23 -0400 X-IronPort-AV: E=Sophos;i="5.68,250,1569276000"; d="scan'208";a="325190605" Received: from abo-45-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.45]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2019 07:39:20 +0100 Date: Thu, 31 Oct 2019 07:39:20 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Gabriela Bittencourt cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org, nishkadg.linux@gmail.com, kim.jamie.bradley@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org Subject: Re: [Outreachy kernel] [PATCH v3 2/3] staging: rts5208: Eliminate the use of Camel Case in files xd.{h,c} In-Reply-To: <20191030190514.10011-3-gabrielabittencourt00@gmail.com> Message-ID: References: <20191030190514.10011-1-gabrielabittencourt00@gmail.com> <20191030190514.10011-3-gabrielabittencourt00@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Oct 2019, Gabriela Bittencourt wrote: > Cleans up checks of "Avoid CamelCase" in files xd.{h,c} > > Signed-off-by: Gabriela Bittencourt Acked-by: Julia Lawall > --- > drivers/staging/rts5208/xd.c | 8 ++++---- > drivers/staging/rts5208/xd.h | 6 +++--- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c > index f3dc96a4c59d..0f369935fb6c 100644 > --- a/drivers/staging/rts5208/xd.c > +++ b/drivers/staging/rts5208/xd.c > @@ -630,13 +630,13 @@ static int reset_xd(struct rtsx_chip *chip) > xd_card->zone_cnt = 32; > xd_card->capacity = 1024000; > break; > - case xD_1G_X8_512: > + case XD_1G_X8_512: > XD_PAGE_512(xd_card); > xd_card->addr_cycle = 4; > xd_card->zone_cnt = 64; > xd_card->capacity = 2048000; > break; > - case xD_2G_X8_512: > + case XD_2G_X8_512: > XD_PAGE_512(xd_card); > xd_card->addr_cycle = 4; > xd_card->zone_cnt = 128; > @@ -669,10 +669,10 @@ static int reset_xd(struct rtsx_chip *chip) > return STATUS_FAIL; > } > > - retval = xd_read_id(chip, READ_xD_ID, id_buf, 4); > + retval = xd_read_id(chip, READ_XD_ID, id_buf, 4); > if (retval != STATUS_SUCCESS) > return STATUS_FAIL; > - dev_dbg(rtsx_dev(chip), "READ_xD_ID: 0x%x 0x%x 0x%x 0x%x\n", > + dev_dbg(rtsx_dev(chip), "READ_XD_ID: 0x%x 0x%x 0x%x 0x%x\n", > id_buf[0], id_buf[1], id_buf[2], id_buf[3]); > if (id_buf[2] != XD_ID_CODE) > return STATUS_FAIL; > diff --git a/drivers/staging/rts5208/xd.h b/drivers/staging/rts5208/xd.h > index 57b94129b26f..98c00f268e56 100644 > --- a/drivers/staging/rts5208/xd.h > +++ b/drivers/staging/rts5208/xd.h > @@ -36,7 +36,7 @@ > #define BLK_ERASE_1 0x60 > #define BLK_ERASE_2 0xD0 > #define READ_STS 0x70 > -#define READ_xD_ID 0x9A > +#define READ_XD_ID 0x9A > #define COPY_BACK_512 0x8A > #define COPY_BACK_2K 0x85 > #define READ1_1_2 0x30 > @@ -72,8 +72,8 @@ > #define XD_128M_X16_2048 0xC1 > #define XD_4M_X8_512_1 0xE3 > #define XD_4M_X8_512_2 0xE5 > -#define xD_1G_X8_512 0xD3 > -#define xD_2G_X8_512 0xD5 > +#define XD_1G_X8_512 0xD3 > +#define XD_2G_X8_512 0xD5 > > #define XD_ID_CODE 0xB5 > > -- > 2.20.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191030190514.10011-3-gabrielabittencourt00%40gmail.com. >