From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F728C432C3 for ; Wed, 13 Nov 2019 22:28:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A71B2206EE for ; Wed, 13 Nov 2019 22:28:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbfKMW24 (ORCPT ); Wed, 13 Nov 2019 17:28:56 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:39286 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbfKMW24 (ORCPT ); Wed, 13 Nov 2019 17:28:56 -0500 Received: from p5b06da22.dip0.t-ipconnect.de ([91.6.218.34] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iV184-0007aP-81; Wed, 13 Nov 2019 23:28:48 +0100 Date: Wed, 13 Nov 2019 23:28:47 +0100 (CET) From: Thomas Gleixner To: Arnd Bergmann cc: y2038@lists.linaro.org, Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org, Anna-Maria Gleixner , Frederic Weisbecker , "Peter Zijlstra (Intel)" , Kees Cook Subject: Re: [PATCH 21/23] y2038: itimer: change implementation to timespec64 In-Reply-To: <20191108211323.1806194-12-arnd@arndb.de> Message-ID: References: <20191108210236.1296047-1-arnd@arndb.de> <20191108211323.1806194-12-arnd@arndb.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Nov 2019, Arnd Bergmann wrote: > TRACE_EVENT(itimer_state, > > - TP_PROTO(int which, const struct itimerval *const value, > + TP_PROTO(int which, const struct itimerspec64 *const value, > unsigned long long expires), > > TP_ARGS(which, value, expires), > @@ -321,12 +321,12 @@ TRACE_EVENT(itimer_state, > __entry->which = which; > __entry->expires = expires; > __entry->value_sec = value->it_value.tv_sec; > - __entry->value_usec = value->it_value.tv_usec; > + __entry->value_usec = value->it_value.tv_nsec / NSEC_PER_USEC; > __entry->interval_sec = value->it_interval.tv_sec; > - __entry->interval_usec = value->it_interval.tv_usec; > + __entry->interval_usec = value->it_interval.tv_nsec / NSEC_PER_USEC; Hmm, having a division in a tracepoint is clearly suboptimal. > ), > > - TP_printk("which=%d expires=%llu it_value=%ld.%ld it_interval=%ld.%ld", > + TP_printk("which=%d expires=%llu it_value=%ld.%06ld it_interval=%ld.%06ld", We print only 6 digits after the . so that would be even correct w/o a division. But it probably does not matter much. > @@ -197,19 +207,13 @@ static void set_cpu_itimer(struct task_struct *tsk, unsigned int clock_id, > #define timeval_valid(t) \ > (((t)->tv_sec >= 0) && (((unsigned long) (t)->tv_usec) < USEC_PER_SEC)) Hrm, why do we have yet another incarnation of timeval_valid()? Can we please have only one (the inline version)? Thanks, tglx