From: Thomas Gleixner <tglx@linutronix.de>
To: Qais Yousef <qais.yousef@arm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Steve Capper <steve.capper@arm.com>,
Richard Fontana <rfontana@redhat.com>,
James Morse <james.morse@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Nicholas Piggin <npiggin@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Jiri Kosina <jkosina@suse.cz>,
Pavankumar Kondeti <pkondeti@codeaurora.org>,
Zhenzhong Duan <zhenzhong.duan@oracle.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/12] arm64: hibernate.c: create a new function to handle cpu_up(sleep_cpu)
Date: Tue, 19 Nov 2019 23:31:38 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1911192326120.6731@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20191030153837.18107-2-qais.yousef@arm.com>
On Wed, 30 Oct 2019, Qais Yousef wrote:
>
> +int hibernation_bringup_sleep_cpu(unsigned int sleep_cpu)
That function name is horrible. Aside of that I really have to ask how you
end up hibernating on an offline CPU?
> +{
> + int ret;
> +
> + if (!cpu_online(sleep_cpu)) {
> + pr_info("Hibernated on a CPU that is offline! Bringing CPU up.\n");
> + ret = cpu_up(sleep_cpu);
> + if (ret) {
> + pr_err("Failed to bring hibernate-CPU up!\n");
> + return ret;
> + }
> + }
> +}
Thanks,
tglx
next prev parent reply other threads:[~2019-11-19 22:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191030153837.18107-1-qais.yousef@arm.com>
2019-10-30 15:38 ` [PATCH 01/12] arm64: hibernate.c: create a new function to handle cpu_up(sleep_cpu) Qais Yousef
2019-11-19 22:31 ` Thomas Gleixner [this message]
2019-11-19 22:51 ` Qais Yousef
2019-11-19 23:01 ` Thomas Gleixner
2019-11-19 23:21 ` Qais Yousef
2019-10-30 15:38 ` [PATCH 02/12] x86: Replace cpu_up/down with devcie_online/offline Qais Yousef
2019-10-30 15:38 ` [PATCH 03/12] powerpc: Replace cpu_up/down with device_online/offline Qais Yousef
2019-11-19 1:19 ` Michael Ellerman
2019-11-19 9:47 ` Qais Yousef
2019-10-30 15:38 ` [PATCH 04/12] ia64: Replace cpu_down with freeze_secondary_cpus Qais Yousef
2019-11-02 4:59 ` kbuild test robot
2019-11-19 22:21 ` Thomas Gleixner
2019-11-19 22:32 ` Qais Yousef
2019-11-19 22:59 ` Thomas Gleixner
2019-11-19 23:19 ` Qais Yousef
2019-11-20 8:46 ` Thomas Gleixner
2019-11-20 10:49 ` Qais Yousef
2019-10-30 15:38 ` [PATCH 05/12] sparc: Replace cpu_up/down with device_online/offline Qais Yousef
2019-10-30 19:33 ` David Miller
2019-10-30 15:38 ` [PATCH 06/12] parisc: " Qais Yousef
2019-11-20 11:09 ` Qais Yousef
2019-11-22 19:51 ` Helge Deller
2019-11-24 10:20 ` Qais Yousef
2019-10-30 15:38 ` [PATCH 07/12] driver: base: cpu: export device_online/offline Qais Yousef
2019-11-02 17:17 ` Greg Kroah-Hartman
2019-10-30 15:38 ` [PATCH 08/12] driver: xen: Replace cpu_up/down with device_online/offline Qais Yousef
2019-10-30 15:38 ` [PATCH 09/12] firmware: psci: " Qais Yousef
2019-10-30 15:38 ` [PATCH 10/12] torture: " Qais Yousef
2019-10-30 15:38 ` [PATCH 11/12] smp: Create a new function to bringup nonboot cpus online Qais Yousef
2019-11-19 22:42 ` Thomas Gleixner
2019-10-30 15:38 ` [PATCH 12/12] cpu: Hide cpu_up/down Qais Yousef
2019-11-19 22:25 ` Thomas Gleixner
2019-11-19 22:36 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911192326120.6731@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=pkondeti@codeaurora.org \
--cc=qais.yousef@arm.com \
--cc=rfontana@redhat.com \
--cc=steve.capper@arm.com \
--cc=will@kernel.org \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).