From: Thomas Gleixner <tglx@linutronix.de>
To: Chen Yu <yu.c.chen@intel.com>
Cc: x86@kernel.org, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Tony Luck <tony.luck@intel.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Michal Hocko <mhocko@suse.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Chen Yu <yu.chen.surf@gmail.com>
Subject: Re: [PATCH][v3] x86/resctrl: Add task resctrl information display
Date: Wed, 20 Nov 2019 12:22:46 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1911201055260.6731@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20191120081628.26701-1-yu.c.chen@intel.com>
On Wed, 20 Nov 2019, Chen Yu wrote:
> Monitoring tools that want to find out which resctrl CTRL
> and MONITOR groups a task belongs to must currently read
> the "tasks" file in every group until they locate the process
> ID.
>
> Add an additional file /proc/{pid}/resctrl to provide this
> information.
>
> For example:
> cat /proc/1193/resctrl
> CTRL_MON:/ctrl_grp0
> MON:/ctrl_grp0/mon_groups/mon_grp0
The formatting is quite ugly and I don't see why this needs to be multiple
lines and have these uppercase prefixes.
A task can only be part of one control group and of one monitoring group
which is associated to the control group. So just providing:
1) ""
2) "/"
3) "/mon_groups/mon0"
4) "/group0"
5) "/group0/mon_groups/mon1"
is simple and clear enough, i.e.:
#1: Resctrl is not available
#2: Task is part of the root group, task not associated to any monitoring
group
#3: Task is part of the root group and monitoring group mon0
#4: Task is part of control group group0, task not associated to any
monitoring group
#5: Task is part of control group group0 and monitoring group mon1
Hmm?
Thanks,
tglx
next prev parent reply other threads:[~2019-11-20 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 8:16 [PATCH][v3] x86/resctrl: Add task resctrl information display Chen Yu
2019-11-20 11:22 ` Thomas Gleixner [this message]
2019-11-22 8:18 ` Yu Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911201055260.6731@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
--cc=yu.chen.surf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).