From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA63C10DCE for ; Sun, 8 Mar 2020 19:33:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E325B2067C for ; Sun, 8 Mar 2020 19:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbgCHTb5 (ORCPT ); Sun, 8 Mar 2020 15:31:57 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:58572 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726318AbgCHTb4 (ORCPT ); Sun, 8 Mar 2020 15:31:56 -0400 X-IronPort-AV: E=Sophos;i="5.70,530,1574118000"; d="scan'208";a="439382032" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2020 20:31:54 +0100 Date: Sun, 8 Mar 2020 20:31:53 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Shreeya Patel cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, sbrivio@redhat.com, daniel.baluta@gmail.com, nramas@linux.microsoft.com, hverkuil@xs4all.nl Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operator In-Reply-To: <20200308192152.26403-1-shreeya.patel23498@gmail.com> Message-ID: References: <20200308192152.26403-1-shreeya.patel23498@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Mar 2020, Shreeya Patel wrote: > Add space around & operator for improving the code > readability. I guess you found this with checkpatch. If so, it could be nice to add "Reported by checkpatch." to the log message. OK otherwise. Acked-by: Julia Lawall > > Signed-off-by: Shreeya Patel > --- > drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c > index e764436e120f..8da955e8343b 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c > +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c > @@ -924,7 +924,7 @@ static void rtw_joinbss_update_network(struct adapter *padapter, struct wlan_net > /* update fw_state will clr _FW_UNDER_LINKING here indirectly */ > switch (pnetwork->network.InfrastructureMode) { > case Ndis802_11Infrastructure: > - if (pmlmepriv->fw_state&WIFI_UNDER_WPS) > + if (pmlmepriv->fw_state & WIFI_UNDER_WPS) > pmlmepriv->fw_state = WIFI_STATION_STATE|WIFI_UNDER_WPS; > else > pmlmepriv->fw_state = WIFI_STATION_STATE; > -- > 2.17.1 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200308192152.26403-1-shreeya.patel23498%40gmail.com. >