* [PATCH] xen/pvcalls-back: test for errors when calling backend_connect()
@ 2020-05-11 7:42 Juergen Gross
2020-05-11 21:41 ` Stefano Stabellini
0 siblings, 1 reply; 3+ messages in thread
From: Juergen Gross @ 2020-05-11 7:42 UTC (permalink / raw)
To: xen-devel, linux-kernel
Cc: Juergen Gross, Boris Ostrovsky, Stefano Stabellini, stable
backend_connect() can fail, so switch the device to connected only if
no error occurred.
Fixes: 0a9c75c2c7258f2 ("xen/pvcalls: xenbus state handling")
Cc: stable@vger.kernel.org
Signed-off-by: Juergen Gross <jgross@suse.com>
---
drivers/xen/pvcalls-back.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index cf4ce3e9358d..41a18ece029a 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -1088,7 +1088,8 @@ static void set_backend_state(struct xenbus_device *dev,
case XenbusStateInitialised:
switch (state) {
case XenbusStateConnected:
- backend_connect(dev);
+ if (backend_connect(dev))
+ return;
xenbus_switch_state(dev, XenbusStateConnected);
break;
case XenbusStateClosing:
--
2.26.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/pvcalls-back: test for errors when calling backend_connect()
2020-05-11 7:42 [PATCH] xen/pvcalls-back: test for errors when calling backend_connect() Juergen Gross
@ 2020-05-11 21:41 ` Stefano Stabellini
2020-05-12 4:24 ` Jürgen Groß
0 siblings, 1 reply; 3+ messages in thread
From: Stefano Stabellini @ 2020-05-11 21:41 UTC (permalink / raw)
To: Juergen Gross
Cc: xen-devel, linux-kernel, Boris Ostrovsky, Stefano Stabellini, stable
On Mon, 11 May 2020, Juergen Gross wrote:
> backend_connect() can fail, so switch the device to connected only if
> no error occurred.
>
> Fixes: 0a9c75c2c7258f2 ("xen/pvcalls: xenbus state handling")
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> drivers/xen/pvcalls-back.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
> index cf4ce3e9358d..41a18ece029a 100644
> --- a/drivers/xen/pvcalls-back.c
> +++ b/drivers/xen/pvcalls-back.c
> @@ -1088,7 +1088,8 @@ static void set_backend_state(struct xenbus_device *dev,
> case XenbusStateInitialised:
> switch (state) {
> case XenbusStateConnected:
> - backend_connect(dev);
> + if (backend_connect(dev))
> + return;
Do you think it would make sense to WARN?
> xenbus_switch_state(dev, XenbusStateConnected);
> break;
> case XenbusStateClosing:
> --
> 2.26.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/pvcalls-back: test for errors when calling backend_connect()
2020-05-11 21:41 ` Stefano Stabellini
@ 2020-05-12 4:24 ` Jürgen Groß
0 siblings, 0 replies; 3+ messages in thread
From: Jürgen Groß @ 2020-05-12 4:24 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: xen-devel, linux-kernel, Boris Ostrovsky, stable
On 11.05.20 23:41, Stefano Stabellini wrote:
> On Mon, 11 May 2020, Juergen Gross wrote:
>> backend_connect() can fail, so switch the device to connected only if
>> no error occurred.
>>
>> Fixes: 0a9c75c2c7258f2 ("xen/pvcalls: xenbus state handling")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>
>
>> ---
>> drivers/xen/pvcalls-back.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
>> index cf4ce3e9358d..41a18ece029a 100644
>> --- a/drivers/xen/pvcalls-back.c
>> +++ b/drivers/xen/pvcalls-back.c
>> @@ -1088,7 +1088,8 @@ static void set_backend_state(struct xenbus_device *dev,
>> case XenbusStateInitialised:
>> switch (state) {
>> case XenbusStateConnected:
>> - backend_connect(dev);
>> + if (backend_connect(dev))
>> + return;
>
> Do you think it would make sense to WARN?
There already should be an error message (either due to a failed
grant mapping or a failed memory allocation).
Juergen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-12 4:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11 7:42 [PATCH] xen/pvcalls-back: test for errors when calling backend_connect() Juergen Gross
2020-05-11 21:41 ` Stefano Stabellini
2020-05-12 4:24 ` Jürgen Groß
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).