From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [linux-safety] [PATCH] e1000: drop unneeded assignment in e1000_set_itr()
Date: Mon, 12 Oct 2020 15:49:48 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2010121546470.6487@felia> (raw)
In-Reply-To: <20201011212326.2758-1-sudipm.mukherjee@gmail.com>
On Sun, 11 Oct 2020, Sudip Mukherjee wrote:
> The variable 'current_itr' is assigned to 0 before jumping to
> 'set_itr_now' but it has not been used after the jump. So, remove the
> unneeded assignement.
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
> drivers/net/ethernet/intel/e1000/e1000_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
> index 5e28cf4fa2cd..042de276e632 100644
> --- a/drivers/net/ethernet/intel/e1000/e1000_main.c
> +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
> @@ -2632,7 +2632,6 @@ static void e1000_set_itr(struct e1000_adapter *adapter)
>
> /* for non-gigabit speeds, just fix the interrupt rate at 4000 */
> if (unlikely(adapter->link_speed != SPEED_1000)) {
> - current_itr = 0;
> new_itr = 4000;
> goto set_itr_now;
> }
Alternatively, you could just inline the max(...) into the switch and
completely drop the current_itr definition.
But your solution probably does the job: it is a "No functional change"
commit.
Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Lukas
> --
> 2.11.0
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#77): https://lists.elisa.tech/g/linux-safety/message/77
> Mute This Topic: https://lists.elisa.tech/mt/77448709/1714638
> Group Owner: linux-safety+owner@lists.elisa.tech
> Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [lukas.bulwahn@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
>
prev parent reply other threads:[~2020-10-12 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 21:23 [PATCH] e1000: drop unneeded assignment in e1000_set_itr() Sudip Mukherjee
2020-10-12 13:49 ` Lukas Bulwahn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2010121546470.6487@felia \
--to=lukas.bulwahn@gmail.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-safety@lists.elisa.tech \
--cc=netdev@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).