linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jens Axboe <axboe@kernel.dk>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linux-ide@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 04/10] MIPS: disable CONFIG_IDE in sb1250_swarm_defconfig
Date: Fri, 19 Mar 2021 01:12:38 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.2103190042210.21463@angie.orcam.me.uk> (raw)
In-Reply-To: <20210318045706.200458-5-hch@lst.de>

On Thu, 18 Mar 2021, Christoph Hellwig wrote:

> sb1250_swarm_defconfig enables CONFIG_IDE but no actual host controller
> driver, so just drop CONFIG_IDE, CONFIG_BLK_DEV_IDECD and
> CONFIG_BLK_DEV_IDETAPE as they are useless.

 Actually BLK_DEV_PLATFORM would handle the SWARM's platform driver as an 
IDE device, however the driver has supported libata ever since commit 
2fef357cf391 ("IDE: Fix platform device registration in Swarm IDE driver 
(v2)") back in 2008, so this is good to go.  We should probably enable 
PATA_PLATFORM in the defconfig instead.

 The printed name of the driver could be improved I suppose though:

scsi host0: pata_platform
ata1: PATA max PIO0 mmio cmd 0x100b3e00 ctl 0x100b7ec0 irq 36

(PIO3 is actually hardwired; it's an odd interface and people reported 
issues with it, but I have never had any myself be it with IDE or libata).

Acked-by: Maciej W. Rozycki <macro@orcam.me.uk>

  Maciej

  reply	other threads:[~2021-03-19  0:13 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18  4:56 remove the legacy ide driver Christoph Hellwig
2021-03-18  4:56 ` [PATCH 01/10] alpha: use libata instead of " Christoph Hellwig
2021-03-18  5:54   ` Al Viro
2021-03-18  6:07     ` Christoph Hellwig
2021-03-18 17:09       ` Måns Rullgård
2021-03-18 18:03         ` Måns Rullgård
2021-03-18  7:54     ` John Paul Adrian Glaubitz
2021-03-19 16:23     ` Serge Belyshev
2021-03-18  4:56 ` [PATCH 02/10] ARM: disable CONFIG_IDE in footbridge_defconfig Christoph Hellwig
2021-03-19 17:07   ` Russell King - ARM Linux admin
2021-03-19 17:53     ` Russell King - ARM Linux admin
2021-03-22 14:54       ` Christoph Hellwig
2021-03-22 15:15         ` Russell King - ARM Linux admin
2021-03-22 15:18           ` Christoph Hellwig
2021-03-22 15:33             ` Christoph Hellwig
2021-03-23 14:03               ` Russell King - ARM Linux admin
2021-03-22 16:59             ` Russell King - ARM Linux admin
2021-03-22 16:09           ` John Paul Adrian Glaubitz
2021-03-22 16:47             ` Cye Borg
2021-03-22 17:03             ` Russell King - ARM Linux admin
2021-03-22 17:10               ` Cye Borg
2021-03-23 18:43                 ` Russell King - ARM Linux admin
2021-03-24  5:47                   ` Cye Borg
2021-03-18  4:56 ` [PATCH 03/10] ARM: disable CONFIG_IDE in pxa_defconfig Christoph Hellwig
2021-03-18  4:57 ` [PATCH 04/10] MIPS: disable CONFIG_IDE in sb1250_swarm_defconfig Christoph Hellwig
2021-03-19  0:12   ` Maciej W. Rozycki [this message]
2021-03-24  9:59   ` Thomas Bogendoerfer
2021-03-18  4:57 ` [PATCH 05/10] MIPS: switch workpad_defconfig from legacy IDE to libata Christoph Hellwig
2021-03-24 10:00   ` Thomas Bogendoerfer
2021-03-18  4:57 ` [PATCH 06/10] MIPS: disable CONFIG_IDE in rbtx49xx_defconfig Christoph Hellwig
2021-03-24 10:00   ` Thomas Bogendoerfer
2021-03-18  4:57 ` [PATCH 07/10] MIPS: disable CONFIG_IDE in bigsur_defconfig Christoph Hellwig
2021-03-18 10:08   ` Sergei Shtylyov
2021-03-24 10:00   ` Thomas Bogendoerfer
2021-03-18  4:57 ` [PATCH 08/10] MIPS: disable CONFIG_IDE in malta*_defconfig Christoph Hellwig
2021-03-18 10:12   ` Sergei Shtylyov
2021-03-18 14:19   ` Thomas Bogendoerfer
2021-03-19 13:03     ` Christoph Hellwig
2021-03-24 10:01   ` Thomas Bogendoerfer
2021-03-18  4:57 ` [PATCH 09/10] m68k: use libata instead of the legacy ide driver Christoph Hellwig
2021-03-18  4:57 ` [PATCH 10/10] ide: remove " Christoph Hellwig
2021-03-20  3:44   ` Maciej W. Rozycki
2021-03-20  4:04     ` Maciej W. Rozycki
2021-03-19  1:43 ` Finn Thain
2021-03-19  5:43   ` Christoph Hellwig
2021-03-19 16:48 ` Maciej W. Rozycki
2021-03-21  9:20 ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2103190042210.21463@angie.orcam.me.uk \
    --to=macro@orcam.me.uk \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=hch@lst.de \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mattst88@gmail.com \
    --cc=mpe@ellerman.id.au \
    --cc=rth@twiddle.net \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).