From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20065C43381 for ; Fri, 19 Mar 2021 00:13:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D36A264EB9 for ; Fri, 19 Mar 2021 00:13:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233262AbhCSANE (ORCPT ); Thu, 18 Mar 2021 20:13:04 -0400 Received: from angie.orcam.me.uk ([157.25.102.26]:37820 "EHLO angie.orcam.me.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbhCSAMm (ORCPT ); Thu, 18 Mar 2021 20:12:42 -0400 Received: by angie.orcam.me.uk (Postfix, from userid 500) id 0DF1592009C; Fri, 19 Mar 2021 01:12:38 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id F30ED92009B; Fri, 19 Mar 2021 01:12:38 +0100 (CET) Date: Fri, 19 Mar 2021 01:12:38 +0100 (CET) From: "Maciej W. Rozycki" To: Christoph Hellwig cc: "David S. Miller" , Jens Axboe , Geert Uytterhoeven , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Thomas Bogendoerfer , Michael Ellerman , linux-ide@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 04/10] MIPS: disable CONFIG_IDE in sb1250_swarm_defconfig In-Reply-To: <20210318045706.200458-5-hch@lst.de> Message-ID: References: <20210318045706.200458-1-hch@lst.de> <20210318045706.200458-5-hch@lst.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Mar 2021, Christoph Hellwig wrote: > sb1250_swarm_defconfig enables CONFIG_IDE but no actual host controller > driver, so just drop CONFIG_IDE, CONFIG_BLK_DEV_IDECD and > CONFIG_BLK_DEV_IDETAPE as they are useless. Actually BLK_DEV_PLATFORM would handle the SWARM's platform driver as an IDE device, however the driver has supported libata ever since commit 2fef357cf391 ("IDE: Fix platform device registration in Swarm IDE driver (v2)") back in 2008, so this is good to go. We should probably enable PATA_PLATFORM in the defconfig instead. The printed name of the driver could be improved I suppose though: scsi host0: pata_platform ata1: PATA max PIO0 mmio cmd 0x100b3e00 ctl 0x100b7ec0 irq 36 (PIO3 is actually hardwired; it's an odd interface and people reported issues with it, but I have never had any myself be it with IDE or libata). Acked-by: Maciej W. Rozycki Maciej