From: Stefano Stabellini <sstabellini@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Bhaskar Chowdhury <unixbhaskar@gmail.com>,
linux@armlinux.org.uk, xen-devel@lists.xenproject.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, jgross@suse.com,
boris.ostrovsky@oracle.com
Subject: Re: [PATCH] ARM: xen/mm.c: A mundane typo fix
Date: Wed, 24 Mar 2021 12:11:33 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.2103241203140.439@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <5e1b573a-6dc7-7f28-28ae-c509e6782fbf@infradead.org>
On Wed, 24 Mar 2021, Randy Dunlap wrote:
> On 3/24/21 11:55 AM, Stefano Stabellini wrote:
> > On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote:
> >> s/acrros/across/
> >>
> >> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> >
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >
> >
>
> Hi,
> It seems to me like some of those "page" should be "pages".
Yes, good point actually
> >> ---
> >> arch/arm/xen/mm.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> >> index 467fa225c3d0..be7c942c74bf 100644
> >> --- a/arch/arm/xen/mm.c
> >> +++ b/arch/arm/xen/mm.c
> >> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
> >> * - The Linux page refers to foreign memory
> >> * - The device doesn't support coherent DMA request
> >> *
> >> - * The Linux page may be spanned acrros multiple Xen page, although>> + * The Linux page may be spanned across multiple Xen page, although
>
> pages,
>
> >> * it's not possible to have a mix of local and foreign Xen page.
>
> pages.
yes to both
> >> * Furthermore, range_straddles_page_boundary is already checking
> >> * if buffer is physically contiguous in the host RAM.
> >> --
>
>
> --
> ~Randy
>
next prev parent reply other threads:[~2021-03-24 19:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 13:30 [PATCH] ARM: xen/mm.c: A mundane typo fix Bhaskar Chowdhury
2021-03-24 18:55 ` Stefano Stabellini
2021-03-24 18:59 ` Randy Dunlap
2021-03-24 19:11 ` Stefano Stabellini [this message]
2021-03-25 4:37 ` Bhaskar Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2103241203140.439@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rdunlap@infradead.org \
--cc=unixbhaskar@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).