From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F7C1C43140 for ; Wed, 12 May 2021 20:46:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22F8B611BF for ; Wed, 12 May 2021 20:46:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1388082AbhELUmA (ORCPT ); Wed, 12 May 2021 16:42:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1387194AbhELUdC (ORCPT ); Wed, 12 May 2021 16:33:02 -0400 Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::4]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0AC30C0612AD; Wed, 12 May 2021 13:23:49 -0700 (PDT) Received: by angie.orcam.me.uk (Postfix, from userid 500) id BA9D992009C; Wed, 12 May 2021 22:22:21 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id AD48792009B; Wed, 12 May 2021 22:22:21 +0200 (CEST) Date: Wed, 12 May 2021 22:22:21 +0200 (CEST) From: "Maciej W. Rozycki" To: Thomas Bogendoerfer , Greg Kroah-Hartman cc: Nathan Chancellor , Naresh Kamboju , open list , Shuah Khan , Florian Fainelli , patches@kernelci.org, lkft-triage@lists.linaro.org, Jon Hunter , linux-stable , Pavel Machek , Andrew Morton , Linus Torvalds , Guenter Roeck , clang-built-linux , Huacai Chen Subject: Re: [PATCH 5.12 000/677] 5.12.4-rc1 review In-Reply-To: Message-ID: References: <20210512144837.204217980@linuxfoundation.org> <8615959b-9054-5c9f-0afa-f15672274d12@kernel.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 May 2021, Greg Kroah-Hartman wrote: > > > > > > mips clang build breaks on stable rc 5.4 .. 5.12 due to below warnings / errors > > > > > > - mips (defconfig) with clang-12 > > > > > > - mips (tinyconfig) with clang-12 > > > > > > - mips (allnoconfig) with clang-12 > > > > > > > > > > > > make --silent --keep-going --jobs=8 > > > > > > O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=mips > > > > > > CROSS_COMPILE=mips-linux-gnu- 'HOSTCC=sccache clang' 'CC=sccache > > > > > > clang' > > > > > > kernel/time/hrtimer.c:318:2: error: couldn't allocate output register > > > > > > for constraint 'x' > > > > > > do_div(tmp, (u32) div); > > > > > > ^ > > > > > > include/asm-generic/div64.h:243:11: note: expanded from macro 'do_div' > > > > > > __rem = __div64_32(&(n), __base); \ > > > > > > ^ > > > > > > arch/mips/include/asm/div64.h:74:11: note: expanded from macro '__div64_32' > > > > > > __asm__("divu $0, %z1, %z2" \ > > > > > > ^ > > > > > > 1 error generated. > > > > > > > > > > Does this also show up in Linus's tree? The same MIPS patch is there as > > > > > well from what I can tell. > > > > > > > > No. > > > > Linus's tree builds MIPS clang successfully. > > > > > > Ick, ok, I'll go drop this and let a MIPS developer send us the correct > > > thing. > > > > > > thanks! > > > > > > greg k-h > > > > > > > I think you just need to grab commits c1d337d45ec0 ("MIPS: Avoid DIVU in > > `__div64_32' is result would be zero") and 25ab14cbe9d1 ("MIPS: Avoid > > handcoded DIVU in `__div64_32' altogether") to fix this up. > > It was easier for me to drop it, let's see if any MIPS developers (are > there any anymore?) care enough to send the proper series. Thomas, I told you it would work better if the original fix was replaced ahead of a pull request to Linus rather than updated with the follow-ups. Will you be able to fix up the mess in this case? I can offer no more than just the commits quoted above, there's no better fix. Maciej