From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] PCI: Do not restore firmware BAR assignments behind a PCI-PCI bridge
Date: Thu, 8 Jul 2021 22:18:55 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2107082210480.6599@angie.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.2.21.2104211620400.44318@angie.orcam.me.uk>
On Wed, 7 Jul 2021, Maciej W. Rozycki wrote:
> This may work for a device directly on the root bus decoded by the host
> bridge only, but for a device behind one or more PCI-to-PCI (or CardBus)
> bridges those bridges' forwarding windows have been standardised and
> need to be respected, or leaving whatever has been there in a downstream
> device's BAR will have no effect as cycles for the addresses recorded
> there will have no chance to appear on the bus the device has been
> immediately attached to.
>
> Do not restore the firmware assignment for a device behind a PCI-to-PCI
> bridge then, fixing the system concerned as follows:
Scrap it.
Something kept bothering me about this fix and I have double-checked with
PR 16263, and the problematic device there also was behind a PCI-to-PCI
bridge, which I have somehow missed previously, though within the bridge's
forwarding window. So a more stringent rule will be required to keep both
cases happy and I'll make v2 shortly that only refrains from restoring the
original assignment when it is outside the relevant upstream bridge's
forwarding window.
Maciej
prev parent reply other threads:[~2021-07-08 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 21:23 [PATCH] PCI: Do not restore firmware BAR assignments behind a PCI-PCI bridge Maciej W. Rozycki
2021-07-08 20:18 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2107082210480.6599@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).