From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB81C433F5 for ; Thu, 21 Apr 2022 21:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442160AbiDUVlI (ORCPT ); Thu, 21 Apr 2022 17:41:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442141AbiDUVlD (ORCPT ); Thu, 21 Apr 2022 17:41:03 -0400 Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5D3414BFE0; Thu, 21 Apr 2022 14:38:12 -0700 (PDT) Received: by angie.orcam.me.uk (Postfix, from userid 500) id 1C5F992009C; Thu, 21 Apr 2022 23:38:11 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 1626E92009B; Thu, 21 Apr 2022 22:38:11 +0100 (BST) Date: Thu, 21 Apr 2022 22:38:10 +0100 (BST) From: "Maciej W. Rozycki" To: Greg Kroah-Hartman cc: Jiri Slaby , Andy Shevchenko , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND][PATCH v3 1/2] serial: 8250: Fold EndRun device support into OxSemi Tornado code In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Apr 2022, Greg Kroah-Hartman wrote: > > > As per the top of this file, this should not be needed here as you are > > > only using it in one file. Please leave it as-is. > > > > I find this requirement silly, but here it's not the place to discuss it, > > You have not had to deal with merge issues in this file before. Think > about every single PCI driver author updating this single file. That > just does not work at the scale we run at, sorry. I put this rule into > place 15+ years ago for that reason. Fair enough, I missed this practical aspect. Thanks for straightening me out. Maciej