From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Stephen Zhang <starzhangzsd@gmail.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Joshua Kinard <kumba@gentoo.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] MIPS: IP27: Remove incorrect `cpu_has_fpu' override
Date: Sat, 30 Apr 2022 16:09:24 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2204301607380.9383@angie.orcam.me.uk> (raw)
In-Reply-To: <CANubcdU99rke6AM4bQEyPNTkJbk1kMit1UVyDggTwTciTUeQMA@mail.gmail.com>
On Sat, 30 Apr 2022, Stephen Zhang wrote:
> > Remove unsupported forcing of `cpu_has_fpu' to 1, which makes the `nofpu'
> > kernel parameter non-functional, and also causes a link error:
> >
> > ld: arch/mips/kernel/traps.o: in function `trap_init':
> > ./arch/mips/include/asm/msa.h:(.init.text+0x348): undefined reference to `handle_fpe'
> > ld: ./arch/mips/include/asm/msa.h:(.init.text+0x354): undefined reference to `handle_fpe'
> > ld: ./arch/mips/include/asm/msa.h:(.init.text+0x360): undefined reference to `handle_fpe'
> >
> > where the CONFIG_MIPS_FP_SUPPORT configuration option has been chosen.
> >
>
> Sorry, but I have a question. From the code in
> arch/mips/kernel/genex.S:567, 'handle_fpe’‘s
> definition is controlled by CONFIG_MIPS_FP_SUPPORT. Then how can it
> still report such
> error when the CONFIG_MIPS_FP_SUPPORT configuration option has been chosen.
Good catch, thanks! For some reason I inverted the condition in my mind
as I wrote the change description. I have now posted v2 with the mistake
corrected.
Maciej
next prev parent reply other threads:[~2022-04-30 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 14:57 [PATCH 0/2] MIPS: Remove incorrect `cpu_has_fpu' overrides Maciej W. Rozycki
2022-04-29 14:57 ` [PATCH 1/2] MIPS: IP27: Remove incorrect `cpu_has_fpu' override Maciej W. Rozycki
2022-04-30 5:34 ` Stephen Zhang
2022-04-30 15:09 ` Maciej W. Rozycki [this message]
2022-04-29 14:57 ` [PATCH 2/2] MIPS: IP30: " Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2204301607380.9383@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=kumba@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=starzhangzsd@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).