linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: Anup Patel <Anup.Patel@wdc.com>
Cc: Palmer Dabbelt <palmer@sifive.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Anup Patel <anup@brainfault.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Atish Patra <Atish.Patra@wdc.com>,
	Alistair Francis <Alistair.Francis@wdc.com>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] RISC-V: Enable SYSCON reboot and poweroff drivers
Date: Mon, 11 Nov 2019 17:06:26 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.21.999.1911111705350.30304@utopia.booyaka.com> (raw)
In-Reply-To: <20191111133421.14390-1-anup.patel@wdc.com>

On Mon, 11 Nov 2019, Anup Patel wrote:

> We can use SYSCON reboot and poweroff drivers for the
> SiFive test device found on QEMU virt machine and SiFive
> SOCs.
> 
> This patch enables SYSCON reboot and poweroff drivers
> in RV64 and RV32 defconfigs.
> 
> Signed-off-by: Anup Patel <anup.patel@wdc.com>

I'd much prefer Christoph's driver, once it's fixed up per my earlier 
comments.  This business with writing random registers based on what's in 
the DT data has always been a bad idea.


- Paul

  parent reply	other threads:[~2019-11-11 17:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11 13:34 [PATCH] RISC-V: Enable SYSCON reboot and poweroff drivers Anup Patel
2019-11-11 13:43 ` Anup Patel
2019-11-11 14:05   ` David Abdurachmanov
2019-11-11 14:08 ` Andreas Schwab
2019-11-11 14:21   ` Anup Patel
2019-11-11 14:32     ` Andreas Schwab
2019-11-11 16:51       ` Anup Patel
2019-11-11 16:55         ` Andreas Schwab
2019-11-11 16:59           ` Christoph Hellwig
2019-11-11 17:01           ` David Abdurachmanov
2019-11-11 17:05             ` Andreas Schwab
2019-11-11 17:06 ` Paul Walmsley [this message]
2019-11-12  4:19   ` Anup Patel
2019-11-23  3:03 ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.999.1911111705350.30304@utopia.booyaka.com \
    --to=paul@pwsan.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=Anup.Patel@wdc.com \
    --cc=Atish.Patra@wdc.com \
    --cc=anup@brainfault.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@sifive.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).