From: Paul Walmsley <paul.walmsley@sifive.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: paul.walmsley@sifive.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
jimw@sifive.com, Michal Marek <michal.lkml@markovi.net>,
Sam Ravnborg <sam@ravnborg.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH v2 2/2] modpost: skip ELF local symbols by default during section mismatch check
Date: Wed, 21 Nov 2018 09:52:52 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1811210950100.18372@viisi.sifive.com> (raw)
In-Reply-To: <CAK7LNAQqpzJcxZBvZY1Bd2sVUwTLg7eD2mq61hDOw6Ek=akdfw@mail.gmail.com>
Hello Masahiro,
On Wed, 21 Nov 2018, Masahiro Yamada wrote:
> I think this is almost good.
> Just a nit.
>
> Maybe, putting this check in secref_whitelist()
> (with a comment "Pattern 6:")
> could look more consistency.
>
>
> Also, if you use strstart() helper,
> you can remove is_local_symbol() function.
>
>
> /* Check for pattern 6 */
> if (strstarts(fromsym, ".L"))
> return 0;
>
Thank you for your suggestion. This change is a definite improvement.
The patch has been updated, and I will repost the patch after it's been
tested.
Best regards,
- Paul
prev parent reply other threads:[~2018-11-21 17:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 0:56 [PATCH v2 0/2] modpost: skip section mismatch warnings on ELF local symbols by default Paul Walmsley
2018-11-15 0:56 ` [PATCH v2 1/2] modpost: drop unused command line switches Paul Walmsley
2018-11-16 19:51 ` Sam Ravnborg
2018-11-21 6:14 ` Masahiro Yamada
2018-11-15 0:56 ` [PATCH v2 2/2] modpost: skip ELF local symbols by default during section mismatch check Paul Walmsley
2018-11-16 19:52 ` Sam Ravnborg
2018-11-21 6:13 ` Masahiro Yamada
2018-11-21 17:52 ` Paul Walmsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1811210950100.18372@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=jimw@sifive.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.lkml@markovi.net \
--cc=paul@pwsan.com \
--cc=sam@ravnborg.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).