From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB725C433FF for ; Wed, 14 Aug 2019 20:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 712892084F for ; Wed, 14 Aug 2019 20:09:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="b7YT4qyJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728736AbfHNUJv (ORCPT ); Wed, 14 Aug 2019 16:09:51 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:42632 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726522AbfHNUJv (ORCPT ); Wed, 14 Aug 2019 16:09:51 -0400 Received: by mail-oi1-f193.google.com with SMTP id o6so5559866oic.9 for ; Wed, 14 Aug 2019 13:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=paXj73KYL+NWP5ZXUWHWrPw2G6gc8123BvsposI90Bo=; b=b7YT4qyJQvfxELhlzPTrHH9UpVblpaV25D445MXc6bb+UY+fVx/aeZtzluWXnKPiWx jLuBLH/LeBWfVk2g1vd1tse0uAz3PZeuueEbpkgm6PbLhYKVaj+yAg2k81C1vkNNicdw qvYHxRhCDaRSKMdkm+fPpYQQC3GWt3tbevb4ZbBZhQrkKrw4H+lGfyI8INn0MokKpYHm WdkXWh1lOe6hWeYivy4SNAuUIUZ9QlUQniBqy5T/EvAVpq3cqyzEvWIiAtRB0j+6QvEc 3B7eaIFT5XRK23QpfIU+qyWCWEa8Ee3GOwZuianuwIzkJZagOL7JoKMKqcDXbYeKqqmS J/cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=paXj73KYL+NWP5ZXUWHWrPw2G6gc8123BvsposI90Bo=; b=ojuGTysIgu9VVkeGNFamSZqI7KoaAwJfLRPvfQhrHnqT+/QnyQswWq6PWjOL8BxGEb VDmMo+x+SdxvdFVw4n4R4D9SZIx4HjG5SO3R47VI4n6DzHeQyCCPrpTqDqYHrVR1g/cw eqRiBqt6S9PCmRZN9gr8dQX29B/olp8K5QiIxffvIv7WHwj4xTFUKzIcZMmFfFOByQ8/ M4YX9YuFEB0SkGZhHF6NRy8gY2XxI0ZRri7CkC+tPYmYgIf7z2eCVXV9L2RMl3hI2lBW ZiuLDuJn5QBAloPCv/a4HROdnggbdHJ0m64sOTTnfze41MzQIhoVAzs9x84nxmCrimRE qUaA== X-Gm-Message-State: APjAAAVv6Do1PCidxukqFnT7CZJ5uE/2XnH/s4C0eVC3wb6eYRmmhOeB SA+cNVwo0yHlyko5/T71egcJOA== X-Google-Smtp-Source: APXvYqw1lyPb/CnPlEzGyigLpCsfoIWzRduhjsHvNrNZxuOSSWClhtGRaPdR8iq562gSdVmoVDYHUA== X-Received: by 2002:a02:a503:: with SMTP id e3mr1164929jam.134.1565813389877; Wed, 14 Aug 2019 13:09:49 -0700 (PDT) Received: from localhost (c-73-95-159-87.hsd1.co.comcast.net. [73.95.159.87]) by smtp.gmail.com with ESMTPSA id y25sm1071822iol.59.2019.08.14.13.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2019 13:09:49 -0700 (PDT) Date: Wed, 14 Aug 2019 13:09:48 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Logan Gunthorpe cc: Greentime Hu , Rob Herring , Albert Ou , Andrew Waterman , Palmer Dabbelt , Linux Kernel Mailing List , Stephen Bates , linux-mm@vger.kernel.org, Olof Johansson , greentime.hu@sifive.com, linux-riscv@lists.infradead.org, Michael Clark , Christoph Hellwig Subject: Re: [PATCH v4 2/2] RISC-V: Implement sparsemem In-Reply-To: <26594413-227b-2cc8-0f61-232a6a3907d0@deltatee.com> Message-ID: References: <20190109203911.7887-1-logang@deltatee.com> <0926a261-520e-4c40-f926-ddd40bb8ce44@deltatee.com> <96156909-1453-d487-ff66-a041d67c74d6@deltatee.com> <5506c875-9387-acc9-a7fe-5b7c10036c40@deltatee.com> <0d81412d-73fc-fa56-6f84-dedda72b9cc6@deltatee.com> <26594413-227b-2cc8-0f61-232a6a3907d0@deltatee.com> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Aug 2019, Logan Gunthorpe wrote: > On 2019-08-14 11:40 a.m., Paul Walmsley wrote: > > On Wed, 14 Aug 2019, Logan Gunthorpe wrote: > > > >> On 2019-08-14 7:35 a.m., Greentime Hu wrote: > >> > >>> Maybe this commit explains why it used HAVE_ARCH_PFN_VALID instead of SPARSEMEM. > >>> https://github.com/torvalds/linux/commit/7b7bf499f79de3f6c85a340c8453a78789523f85 > >>> > >>> BTW, I found another issue here. > >>> #define FIXADDR_TOP (VMALLOC_START) > >>> #define FIXADDR_START (FIXADDR_TOP - FIXADDR_SIZE) > >>> #define VMEMMAP_END (VMALLOC_START - 1) > >>> #define VMEMMAP_START (VMALLOC_START - VMEMMAP_SIZE) > >>> These 2 regions are overlapped. > >>> > >>> How about this fix? Not sure if it is good for everyone. > >> > >> Yes, this looks good to me. I can fold these changes into my patch and > >> send a v5 to the list. > > > > The change to FIXADDR_TOP should be separated out into its own patch - it > > probably needs to go up as a fix. > > I don't think so... VMEMMAP_START doesn't exist until the sparsemem > patch so it can't be changed until after the sparsemem patch and no > sense adding a bug in the sparsemem patch... OK, that's fine then. - Paul