linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Walmsley <paul.walmsley@sifive.com>
To: Atish Patra <atish.patra@wdc.com>
Cc: linux-kernel@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
	linux-riscv@lists.infradead.org,
	Palmer Dabbelt <palmer@sifive.com>,
	Christoph Hellwig <hch@lst.de>, Anup Patel <Anup.Patel@wdc.com>
Subject: Re: [PATCH v4 0/3] Optimize tlbflush path
Date: Fri, 30 Aug 2019 19:50:33 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.9999.1908301939300.16731@viisi.sifive.com> (raw)
In-Reply-To: <20190822075151.24838-1-atish.patra@wdc.com>

Hi Atish,

On Thu, 22 Aug 2019, Atish Patra wrote:

> This series adds few optimizations to reduce the trap cost in the tlb
> flush path. We should only make SBI calls to remote tlb flush only if
> absolutely required. 

The patches look great.  My understanding is that these optimization 
patches may actually be a partial workaround for the TLB flushing bug that 
we've been looking at for the last month or so, which can corrupt memory 
or crash the system.

If that's the case, let's first root-cause the underlying bug.  Otherwise 
we'll just be papering over the actual issue, which probably could still 
occur even with this series, correct?  Since it contains no explicit 
fixes?


- Paul

  parent reply	other threads:[~2019-08-31  2:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22  7:51 [PATCH v4 0/3] Optimize tlbflush path Atish Patra
2019-08-22  7:51 ` [PATCH v4 1/3] RISC-V: Do not invoke SBI call if cpumask is empty Atish Patra
2019-08-22  8:10   ` Christoph Hellwig
2019-08-22  7:51 ` [PATCH v4 2/3] RISC-V: Issue a local tlbflush if possible Atish Patra
2019-08-22  8:10   ` Christoph Hellwig
2019-08-22  7:51 ` [PATCH v4 3/3] RISC-V: Issue a tlb page flush " Atish Patra
2019-08-22  8:11   ` Christoph Hellwig
2019-08-22 18:31     ` Atish Patra
2019-08-31  2:50 ` Paul Walmsley [this message]
2019-09-28  4:23   ` [PATCH v4 0/3] Optimize tlbflush path Atish Patra
2019-10-25  3:09   ` Paul Walmsley
2019-10-31 15:13     ` Atish Patra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.9999.1908301939300.16731@viisi.sifive.com \
    --to=paul.walmsley@sifive.com \
    --cc=Anup.Patel@wdc.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=atish.patra@wdc.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).