From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLACK,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4007C4CEC9 for ; Tue, 17 Sep 2019 12:15:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97BF5218AC for ; Tue, 17 Sep 2019 12:15:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="Z9hnNWDF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727772AbfIQMPb (ORCPT ); Tue, 17 Sep 2019 08:15:31 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46376 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725270AbfIQMPa (ORCPT ); Tue, 17 Sep 2019 08:15:30 -0400 Received: by mail-wr1-f67.google.com with SMTP id o18so2853997wrv.13 for ; Tue, 17 Sep 2019 05:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=XTkEiDr+Efjwc1YXx3Nos3anR5keJEKk4IdJ0xKDQqQ=; b=Z9hnNWDFFYfXXZtUmieLU1+17tbedb1QQZe6lQmZlJi2KQTfmukKD4mYpdD87AKp8f v70NBwT1bNf0l7pPBtJvRwMbn7MYuKKKse4TSQISZwzayJC9r8gAKN1GrfvJSpGbK4Uo GBJK4yaLWvNwxUgm7MCh4HBPOox79mFdatyuKM/5FekdfhyBWmA4WUDaUWaRr9e6kgTv jDwR02MeGt/Xy7yV59hUfxxvUUW6pVx5yexGyMQQJnVvoyxRh0Y+8dc0O4qz+qHYQMF6 W3/hvjexZH5ZkAGfaKExu73hfGrho6DTILoKAqHFq2saAtrhIzT8FBGHMakAm1Hf09Tk ubQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=XTkEiDr+Efjwc1YXx3Nos3anR5keJEKk4IdJ0xKDQqQ=; b=MI9SSKy63uB9C2CubsN06PRQ5WHdsKEzUAO9TyAs1Ib9EVrEmCapxFlJ4R9250TThy 9P+BJHYvN/Qh9t/XPk8exQy5dPApI+DGA0Po+K+K4IKLIQ/Ipd8p/A+9du/ZbuVQg3v5 CBvgqJ8f89kGkTJc28xJ60sGJhaKYTEPmUiTDZoF7Ddfhy+XwX81648e99IAZQvhcVfX 3swofEHxocFKm76eubUk3CbcR0CyQmZ4E3eai2wcgzNNxnPnJ7HWZxBDrDAgnsummE1w 5yJoh7rgNjGEIUseJLFQa4vS3dnVWcPKIjMNGX1pf5D8gSaTinSHSdEzZR7E9j346b52 hvbQ== X-Gm-Message-State: APjAAAU1NBi1LhiVUhOwfcH1Q8LWAVoo4/3W3a8OC2Yj4AgxpoF+669j koZfvCKcbNhVz/DhdOyieb6KaA== X-Google-Smtp-Source: APXvYqybIIJ4Qs9uNxPcmswpxKdrs6cGATqMPNepsGv9voMWM8blurF16GmXEfIxIJJPNBriP4ED2Q== X-Received: by 2002:adf:f150:: with SMTP id y16mr2587728wro.71.1568722528223; Tue, 17 Sep 2019 05:15:28 -0700 (PDT) Received: from localhost ([195.200.173.126]) by smtp.gmail.com with ESMTPSA id y186sm4139994wmb.41.2019.09.17.05.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2019 05:15:27 -0700 (PDT) Date: Tue, 17 Sep 2019 05:15:26 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Baolin Wang , Aurabindo Jayamohanan cc: Mark Brown , palmer@sifive.com, linux-spi , linux-riscv@lists.infradead.org, LKML Subject: Re: [PATCH] spi: sifive: check return value for platform_get_resource() In-Reply-To: Message-ID: References: <20190917085627.4562-1-mail@aurabindo.in> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Sep 2019, Baolin Wang wrote: > On Tue, 17 Sep 2019 at 17:12, Aurabindo Jayamohanan wrote: > > > > platform_get_resource() may return NULL. If it is so, return -ENXIO > > > > Signed-off-by: Aurabindo Jayamohanan > > --- > > drivers/spi/spi-sifive.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/spi/spi-sifive.c b/drivers/spi/spi-sifive.c > > index 93ec2c6cdbfd..67485067a694 100644 > > --- a/drivers/spi/spi-sifive.c > > +++ b/drivers/spi/spi-sifive.c > > @@ -308,6 +308,12 @@ static int sifive_spi_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, master); > > > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + if (!res) { > > + dev_err(&pdev->dev, "no IOMEM resource found\n"); > > + ret = -ENXIO; > > + goto put_master; > > + } > > Seems unnecessary, the devm_ioremap_resource() already validated if > the resource is available. Just doublechecked lib/devres.c and I agree with you. Aurobindo, is this a patch for a real problem that you've encountered? - Paul