From: Paul Walmsley <paul.walmsley@sifive.com>
To: Alistair Francis <Alistair.Francis@wdc.com>
Cc: Anup Patel <Anup.Patel@wdc.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rkir@google.com" <rkir@google.com>,
"hch@infradead.org" <hch@infradead.org>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"anup@brainfault.org" <anup@brainfault.org>,
"palmer@sifive.com" <palmer@sifive.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] RISC-V: defconfig: Enable Goldfish RTC driver
Date: Tue, 22 Oct 2019 18:06:57 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1910221751500.25457@viisi.sifive.com> (raw)
In-Reply-To: <17db4a6244d09abf867daf2a6c10de6a5cd58c89.camel@wdc.com>
On Tue, 22 Oct 2019, Alistair Francis wrote:
> I think it makese sense for this to go into Linux first.
>
> The QEMU patches are going to be accepted, just some nit picking to do
> first :)
>
> After that we have to wait for a PR and then a QEMU release until most
> people will see the change in QEMU. In that time Linux 5.4 will be
> released, if this can make it into 5.4 then everyone using 5.4 will get
> the new RTC as soon as they upgrade QEMU (QEMU provides the device
> tree). If this has to wait until QEMU has support then it won't be
> supported for users until even later.
>
> Users are generally slow to update kernels (buildroot is still using
> 5.1 by default for example) so the sooner changes like this go in the
> better.
The defconfigs are really just for kernel developers. We expect users to
define their own Kconfigs for their own needs.
If using the Goldfish code really is what we all want to do (see below),
then the kernel patch that should go in right away -- which also has no
dependence on what QEMU does -- would be the first patch of this series:
https://lore.kernel.org/linux-riscv/20190925063706.56175-2-anup.patel@wdc.com/
And that should go in via whoever is maintaining the Goldfish driver, not
the RISC-V tree. (It looks like drivers/platform/goldfish is completely
unmaintained - a red flag! - so probably someone needs to persuade Greg or
Andrew to take it.)
Incidentally, just looking at drivers/platform/goldfish, that driver seems
to be some sort of Google-specific RPC driver. Are you all really sure
you want to enable that just for an RTC? Seems like overkill - there are
much simpler RTCs out there.
- Paul
next prev parent reply other threads:[~2019-10-23 1:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 6:37 [PATCH v2 0/2] Enable Goldfish RTC for RISC-V Anup Patel
2019-09-25 6:37 ` [PATCH v2 1/2] platform: goldfish: Allow goldfish drivers for archs with IOMEM and DMA Anup Patel
2019-09-25 6:38 ` [PATCH v2 2/2] RISC-V: defconfig: Enable Goldfish RTC driver Anup Patel
2019-10-12 17:38 ` Palmer Dabbelt
2019-10-14 9:20 ` Anup Patel
2019-10-22 19:23 ` Paul Walmsley
2019-10-22 22:53 ` Alistair Francis
2019-10-23 1:06 ` Paul Walmsley [this message]
2019-10-23 3:24 ` Anup Patel
2019-10-23 6:00 ` Paul Walmsley
2019-10-23 6:12 ` Anup Patel
2019-10-23 6:49 ` Paul Walmsley
2019-10-23 17:42 ` Alistair Francis
2019-10-23 18:20 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1910221751500.25457@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=rkir@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).