linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Enabling MSI for Microblaze
@ 2019-10-24 10:13 Michal Simek
  2019-10-24 10:13 ` [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Michal Simek @ 2019-10-24 10:13 UTC (permalink / raw)
  To: linux-kernel, monstr, michal.simek, git, palmer, hch, longman, helgaas
  Cc: Paolo Bonzini, Arnd Bergmann, Jackie Liu, Wesley Terpstra,
	Firoz Khan, sparclinux, Ingo Molnar, Catalin Marinas,
	Ard Biesheuvel, linux-riscv, linux-arch, James Hogan,
	Vineet Gupta, Bjorn Helgaas, linux-pci, Greg Kroah-Hartman,
	Ralf Baechle, Paul Walmsley, Peter Zijlstra (Intel),
	Will Deacon, Benjamin Herrenschmidt, Paul Burton, Cornelia Huck,
	Herbert Xu, Russell King, linux-arm-kernel, Albert Ou,
	linux-snps-arc, David S. Miller, Eric Biggers, Michael Ellerman,
	linux-mips, Masahiro Yamada, Paul Mackerras, linuxppc-dev

Hi,

these two patches come from discussion with Christoph, Bjorn, Palmer and
Waiman. The first patch was suggestion by Christoph here
https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/
The second part was discussed
https://lore.kernel.org/linux-pci/mhng-5d9bcb53-225e-441f-86cc-b335624b3e7c@palmer-si-x1e/
and
https://lore.kernel.org/linux-pci/20191017181937.7004-1-palmer@sifive.com/

Thanks,
Michal


Michal Simek (1):
  asm-generic: Make msi.h a mandatory include/asm header

Palmer Dabbelt (1):
  pci: Default to PCI_MSI_IRQ_DOMAIN

 arch/arc/include/asm/Kbuild     | 1 -
 arch/arm/include/asm/Kbuild     | 1 -
 arch/arm64/include/asm/Kbuild   | 1 -
 arch/mips/include/asm/Kbuild    | 1 -
 arch/powerpc/include/asm/Kbuild | 1 -
 arch/riscv/include/asm/Kbuild   | 1 -
 arch/sparc/include/asm/Kbuild   | 1 -
 drivers/pci/Kconfig             | 2 +-
 include/asm-generic/Kbuild      | 1 +
 9 files changed, 2 insertions(+), 8 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header
  2019-10-24 10:13 [PATCH 0/2] Enabling MSI for Microblaze Michal Simek
@ 2019-10-24 10:13 ` Michal Simek
  2019-10-24 14:44   ` Masahiro Yamada
  2019-10-24 15:17   ` Paul Walmsley
  2019-10-24 10:13 ` [PATCH 2/2] pci: Default to PCI_MSI_IRQ_DOMAIN Michal Simek
  2019-10-24 17:03 ` [PATCH 0/2] Enabling MSI for Microblaze Waiman Long
  2 siblings, 2 replies; 7+ messages in thread
From: Michal Simek @ 2019-10-24 10:13 UTC (permalink / raw)
  To: linux-kernel, monstr, michal.simek, git, palmer, hch, longman, helgaas
  Cc: Paolo Bonzini, Arnd Bergmann, Jackie Liu, Wesley Terpstra,
	Firoz Khan, sparclinux, Ingo Molnar, Catalin Marinas,
	Ard Biesheuvel, linux-riscv, linux-arch, James Hogan,
	Vineet Gupta, Greg Kroah-Hartman, Ralf Baechle, Paul Walmsley,
	Peter Zijlstra (Intel),
	Will Deacon, Benjamin Herrenschmidt, Paul Burton, Cornelia Huck,
	Herbert Xu, Russell King, linux-arm-kernel, Albert Ou,
	linux-snps-arc, David S. Miller, Eric Biggers, Michael Ellerman,
	linux-mips, Masahiro Yamada, Paul Mackerras, linuxppc-dev

msi.h is generic for all architectures expect of x86 which has own version.
Enabling MSI by including msi.h to architecture Kbuild is just additional
step which doesn't need to be done.
The patch was created based on request to enable MSI for Microblaze.

Suggested-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/
---
 arch/arc/include/asm/Kbuild     | 1 -
 arch/arm/include/asm/Kbuild     | 1 -
 arch/arm64/include/asm/Kbuild   | 1 -
 arch/mips/include/asm/Kbuild    | 1 -
 arch/powerpc/include/asm/Kbuild | 1 -
 arch/riscv/include/asm/Kbuild   | 1 -
 arch/sparc/include/asm/Kbuild   | 1 -
 include/asm-generic/Kbuild      | 1 +
 8 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/arc/include/asm/Kbuild b/arch/arc/include/asm/Kbuild
index 393d4f5e1450..1b505694691e 100644
--- a/arch/arc/include/asm/Kbuild
+++ b/arch/arc/include/asm/Kbuild
@@ -17,7 +17,6 @@ generic-y += local64.h
 generic-y += mcs_spinlock.h
 generic-y += mm-arch-hooks.h
 generic-y += mmiowb.h
-generic-y += msi.h
 generic-y += parport.h
 generic-y += percpu.h
 generic-y += preempt.h
diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild
index 68ca86f85eb7..fa579b23b4df 100644
--- a/arch/arm/include/asm/Kbuild
+++ b/arch/arm/include/asm/Kbuild
@@ -12,7 +12,6 @@ generic-y += local.h
 generic-y += local64.h
 generic-y += mm-arch-hooks.h
 generic-y += mmiowb.h
-generic-y += msi.h
 generic-y += parport.h
 generic-y += preempt.h
 generic-y += seccomp.h
diff --git a/arch/arm64/include/asm/Kbuild b/arch/arm64/include/asm/Kbuild
index 98a5405c8558..bd23f87d6c55 100644
--- a/arch/arm64/include/asm/Kbuild
+++ b/arch/arm64/include/asm/Kbuild
@@ -16,7 +16,6 @@ generic-y += local64.h
 generic-y += mcs_spinlock.h
 generic-y += mm-arch-hooks.h
 generic-y += mmiowb.h
-generic-y += msi.h
 generic-y += qrwlock.h
 generic-y += qspinlock.h
 generic-y += serial.h
diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild
index c8b595c60910..61b0fc2026e6 100644
--- a/arch/mips/include/asm/Kbuild
+++ b/arch/mips/include/asm/Kbuild
@@ -13,7 +13,6 @@ generic-y += irq_work.h
 generic-y += local64.h
 generic-y += mcs_spinlock.h
 generic-y += mm-arch-hooks.h
-generic-y += msi.h
 generic-y += parport.h
 generic-y += percpu.h
 generic-y += preempt.h
diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
index 64870c7be4a3..17726f2e46de 100644
--- a/arch/powerpc/include/asm/Kbuild
+++ b/arch/powerpc/include/asm/Kbuild
@@ -10,4 +10,3 @@ generic-y += local64.h
 generic-y += mcs_spinlock.h
 generic-y += preempt.h
 generic-y += vtime.h
-generic-y += msi.h
diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
index 16970f246860..1efaeddf1e4b 100644
--- a/arch/riscv/include/asm/Kbuild
+++ b/arch/riscv/include/asm/Kbuild
@@ -22,7 +22,6 @@ generic-y += kvm_para.h
 generic-y += local.h
 generic-y += local64.h
 generic-y += mm-arch-hooks.h
-generic-y += msi.h
 generic-y += percpu.h
 generic-y += preempt.h
 generic-y += sections.h
diff --git a/arch/sparc/include/asm/Kbuild b/arch/sparc/include/asm/Kbuild
index b6212164847b..62de2eb2773d 100644
--- a/arch/sparc/include/asm/Kbuild
+++ b/arch/sparc/include/asm/Kbuild
@@ -18,7 +18,6 @@ generic-y += mcs_spinlock.h
 generic-y += mm-arch-hooks.h
 generic-y += mmiowb.h
 generic-y += module.h
-generic-y += msi.h
 generic-y += preempt.h
 generic-y += serial.h
 generic-y += trace_clock.h
diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild
index adff14fcb8e4..ddfee1bd9dc1 100644
--- a/include/asm-generic/Kbuild
+++ b/include/asm-generic/Kbuild
@@ -4,4 +4,5 @@
 # (This file is not included when SRCARCH=um since UML borrows several
 # asm headers from the host architecutre.)
 
+mandatory-y += msi.h
 mandatory-y += simd.h
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] pci: Default to PCI_MSI_IRQ_DOMAIN
  2019-10-24 10:13 [PATCH 0/2] Enabling MSI for Microblaze Michal Simek
  2019-10-24 10:13 ` [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
@ 2019-10-24 10:13 ` Michal Simek
  2019-10-24 17:03 ` [PATCH 0/2] Enabling MSI for Microblaze Waiman Long
  2 siblings, 0 replies; 7+ messages in thread
From: Michal Simek @ 2019-10-24 10:13 UTC (permalink / raw)
  To: linux-kernel, monstr, michal.simek, git, palmer, hch, longman, helgaas
  Cc: Bjorn Helgaas, linux-pci

From: Palmer Dabbelt <palmer@sifive.com>

As far as I can tell, the only reason there was an architecture
whitelist for PCI_MSI_IRQ_DOMAIN is because it requires msi.h.  I've
built this for all the architectures that play nice with make.cross, but
I haven't boot tested it anywhere.

Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

Origin patch here:
https://lore.kernel.org/linux-pci/20191017181937.7004-4-palmer@sifive.com/

---
 drivers/pci/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
index a304f5ea11b9..77c1428cd945 100644
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -52,7 +52,7 @@ config PCI_MSI
 	   If you don't know what to do here, say Y.
 
 config PCI_MSI_IRQ_DOMAIN
-	def_bool ARC || ARM || ARM64 || X86 || RISCV
+	def_bool y
 	depends on PCI_MSI
 	select GENERIC_MSI_IRQ_DOMAIN
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header
  2019-10-24 10:13 ` [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
@ 2019-10-24 14:44   ` Masahiro Yamada
  2019-10-25  6:12     ` Michal Simek
  2019-10-24 15:17   ` Paul Walmsley
  1 sibling, 1 reply; 7+ messages in thread
From: Masahiro Yamada @ 2019-10-24 14:44 UTC (permalink / raw)
  To: Michal Simek
  Cc: Linux Kernel Mailing List, Michal Simek, git, Palmer Dabbelt,
	Christoph Hellwig, longman, Bjorn Helgaas, Paolo Bonzini,
	Arnd Bergmann, Jackie Liu, Wesley Terpstra, Firoz Khan,
	sparclinux, Ingo Molnar, Catalin Marinas, Ard Biesheuvel,
	linux-riscv, linux-arch, James Hogan, Vineet Gupta,
	Greg Kroah-Hartman, Ralf Baechle, Paul Walmsley,
	Peter Zijlstra (Intel),
	Will Deacon, Benjamin Herrenschmidt, Paul Burton, Cornelia Huck,
	Herbert Xu, Russell King, linux-arm-kernel, Albert Ou, arcml,
	David S. Miller, Eric Biggers, Michael Ellerman, linux-mips,
	Paul Mackerras, linuxppc-dev

On Thu, Oct 24, 2019 at 7:13 PM Michal Simek <michal.simek@xilinx.com> wrote:
>
> msi.h is generic for all architectures expect of x86 which has own version.

Maybe a typo?  "except"


Anyway, the code looks good to me.

Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>


> Enabling MSI by including msi.h to architecture Kbuild is just additional
> step which doesn't need to be done.
> The patch was created based on request to enable MSI for Microblaze.
>
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/
> ---
>  arch/arc/include/asm/Kbuild     | 1 -
>  arch/arm/include/asm/Kbuild     | 1 -
>  arch/arm64/include/asm/Kbuild   | 1 -
>  arch/mips/include/asm/Kbuild    | 1 -
>  arch/powerpc/include/asm/Kbuild | 1 -
>  arch/riscv/include/asm/Kbuild   | 1 -
>  arch/sparc/include/asm/Kbuild   | 1 -
>  include/asm-generic/Kbuild      | 1 +
>  8 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/arch/arc/include/asm/Kbuild b/arch/arc/include/asm/Kbuild
> index 393d4f5e1450..1b505694691e 100644
> --- a/arch/arc/include/asm/Kbuild
> +++ b/arch/arc/include/asm/Kbuild
> @@ -17,7 +17,6 @@ generic-y += local64.h
>  generic-y += mcs_spinlock.h
>  generic-y += mm-arch-hooks.h
>  generic-y += mmiowb.h
> -generic-y += msi.h
>  generic-y += parport.h
>  generic-y += percpu.h
>  generic-y += preempt.h
> diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild
> index 68ca86f85eb7..fa579b23b4df 100644
> --- a/arch/arm/include/asm/Kbuild
> +++ b/arch/arm/include/asm/Kbuild
> @@ -12,7 +12,6 @@ generic-y += local.h
>  generic-y += local64.h
>  generic-y += mm-arch-hooks.h
>  generic-y += mmiowb.h
> -generic-y += msi.h
>  generic-y += parport.h
>  generic-y += preempt.h
>  generic-y += seccomp.h
> diff --git a/arch/arm64/include/asm/Kbuild b/arch/arm64/include/asm/Kbuild
> index 98a5405c8558..bd23f87d6c55 100644
> --- a/arch/arm64/include/asm/Kbuild
> +++ b/arch/arm64/include/asm/Kbuild
> @@ -16,7 +16,6 @@ generic-y += local64.h
>  generic-y += mcs_spinlock.h
>  generic-y += mm-arch-hooks.h
>  generic-y += mmiowb.h
> -generic-y += msi.h
>  generic-y += qrwlock.h
>  generic-y += qspinlock.h
>  generic-y += serial.h
> diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild
> index c8b595c60910..61b0fc2026e6 100644
> --- a/arch/mips/include/asm/Kbuild
> +++ b/arch/mips/include/asm/Kbuild
> @@ -13,7 +13,6 @@ generic-y += irq_work.h
>  generic-y += local64.h
>  generic-y += mcs_spinlock.h
>  generic-y += mm-arch-hooks.h
> -generic-y += msi.h
>  generic-y += parport.h
>  generic-y += percpu.h
>  generic-y += preempt.h
> diff --git a/arch/powerpc/include/asm/Kbuild b/arch/powerpc/include/asm/Kbuild
> index 64870c7be4a3..17726f2e46de 100644
> --- a/arch/powerpc/include/asm/Kbuild
> +++ b/arch/powerpc/include/asm/Kbuild
> @@ -10,4 +10,3 @@ generic-y += local64.h
>  generic-y += mcs_spinlock.h
>  generic-y += preempt.h
>  generic-y += vtime.h
> -generic-y += msi.h
> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> index 16970f246860..1efaeddf1e4b 100644
> --- a/arch/riscv/include/asm/Kbuild
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -22,7 +22,6 @@ generic-y += kvm_para.h
>  generic-y += local.h
>  generic-y += local64.h
>  generic-y += mm-arch-hooks.h
> -generic-y += msi.h
>  generic-y += percpu.h
>  generic-y += preempt.h
>  generic-y += sections.h
> diff --git a/arch/sparc/include/asm/Kbuild b/arch/sparc/include/asm/Kbuild
> index b6212164847b..62de2eb2773d 100644
> --- a/arch/sparc/include/asm/Kbuild
> +++ b/arch/sparc/include/asm/Kbuild
> @@ -18,7 +18,6 @@ generic-y += mcs_spinlock.h
>  generic-y += mm-arch-hooks.h
>  generic-y += mmiowb.h
>  generic-y += module.h
> -generic-y += msi.h
>  generic-y += preempt.h
>  generic-y += serial.h
>  generic-y += trace_clock.h
> diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild
> index adff14fcb8e4..ddfee1bd9dc1 100644
> --- a/include/asm-generic/Kbuild
> +++ b/include/asm-generic/Kbuild
> @@ -4,4 +4,5 @@
>  # (This file is not included when SRCARCH=um since UML borrows several
>  # asm headers from the host architecutre.)
>
> +mandatory-y += msi.h
>  mandatory-y += simd.h
> --
> 2.17.1
>


-- 
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header
  2019-10-24 10:13 ` [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
  2019-10-24 14:44   ` Masahiro Yamada
@ 2019-10-24 15:17   ` Paul Walmsley
  1 sibling, 0 replies; 7+ messages in thread
From: Paul Walmsley @ 2019-10-24 15:17 UTC (permalink / raw)
  To: Michal Simek
  Cc: linux-kernel, monstr, git, palmer, hch, longman, helgaas,
	Paolo Bonzini, Arnd Bergmann, Jackie Liu, Wesley Terpstra,
	Firoz Khan, sparclinux, Ingo Molnar, Catalin Marinas,
	Ard Biesheuvel, linux-riscv, linux-arch, James Hogan,
	Vineet Gupta, Greg Kroah-Hartman, Ralf Baechle,
	Peter Zijlstra (Intel),
	Will Deacon, Benjamin Herrenschmidt, Paul Burton, Cornelia Huck,
	Herbert Xu, Russell King, linux-arm-kernel, Albert Ou,
	linux-snps-arc, David S. Miller, Eric Biggers, Michael Ellerman,
	linux-mips, Masahiro Yamada, Paul Mackerras, linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

On Thu, 24 Oct 2019, Michal Simek wrote:

> msi.h is generic for all architectures expect of x86 which has own version.
> Enabling MSI by including msi.h to architecture Kbuild is just additional
> step which doesn't need to be done.
> The patch was created based on request to enable MSI for Microblaze.
> 
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
> https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/

[ ... ]

> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> index 16970f246860..1efaeddf1e4b 100644
> --- a/arch/riscv/include/asm/Kbuild
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -22,7 +22,6 @@ generic-y += kvm_para.h
>  generic-y += local.h
>  generic-y += local64.h
>  generic-y += mm-arch-hooks.h
> -generic-y += msi.h
>  generic-y += percpu.h
>  generic-y += preempt.h
>  generic-y += sections.h

Acked-by: Paul Walmsley <paul.walmsley@sifive.com> # arch/riscv
Tested-by: Paul Walmsley <paul.walmsley@sifive.com> # build only, rv32/rv64

Thanks Michał,


- Paul

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/2] Enabling MSI for Microblaze
  2019-10-24 10:13 [PATCH 0/2] Enabling MSI for Microblaze Michal Simek
  2019-10-24 10:13 ` [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
  2019-10-24 10:13 ` [PATCH 2/2] pci: Default to PCI_MSI_IRQ_DOMAIN Michal Simek
@ 2019-10-24 17:03 ` Waiman Long
  2 siblings, 0 replies; 7+ messages in thread
From: Waiman Long @ 2019-10-24 17:03 UTC (permalink / raw)
  To: Michal Simek, linux-kernel, monstr, git, palmer, hch, helgaas
  Cc: Paolo Bonzini, Arnd Bergmann, Jackie Liu, Wesley Terpstra,
	Firoz Khan, sparclinux, Ingo Molnar, Catalin Marinas,
	Ard Biesheuvel, linux-riscv, linux-arch, James Hogan,
	Vineet Gupta, Bjorn Helgaas, linux-pci, Greg Kroah-Hartman,
	Ralf Baechle, Paul Walmsley, Peter Zijlstra (Intel),
	Will Deacon, Benjamin Herrenschmidt, Paul Burton, Cornelia Huck,
	Herbert Xu, Russell King, linux-arm-kernel, Albert Ou,
	linux-snps-arc, David S. Miller, Eric Biggers, Michael Ellerman,
	linux-mips, Masahiro Yamada, Paul Mackerras, linuxppc-dev

On 10/24/19 6:13 AM, Michal Simek wrote:
> Hi,
>
> these two patches come from discussion with Christoph, Bjorn, Palmer and
> Waiman. The first patch was suggestion by Christoph here
> https://lore.kernel.org/linux-riscv/20191008154604.GA7903@infradead.org/
> The second part was discussed
> https://lore.kernel.org/linux-pci/mhng-5d9bcb53-225e-441f-86cc-b335624b3e7c@palmer-si-x1e/
> and
> https://lore.kernel.org/linux-pci/20191017181937.7004-1-palmer@sifive.com/
>
> Thanks,
> Michal
>
>
> Michal Simek (1):
>   asm-generic: Make msi.h a mandatory include/asm header
>
> Palmer Dabbelt (1):
>   pci: Default to PCI_MSI_IRQ_DOMAIN
>
>  arch/arc/include/asm/Kbuild     | 1 -
>  arch/arm/include/asm/Kbuild     | 1 -
>  arch/arm64/include/asm/Kbuild   | 1 -
>  arch/mips/include/asm/Kbuild    | 1 -
>  arch/powerpc/include/asm/Kbuild | 1 -
>  arch/riscv/include/asm/Kbuild   | 1 -
>  arch/sparc/include/asm/Kbuild   | 1 -
>  drivers/pci/Kconfig             | 2 +-
>  include/asm-generic/Kbuild      | 1 +
>  9 files changed, 2 insertions(+), 8 deletions(-)
>
That looks OK.

Acked-by: Waiman Long <longman@redhat.com>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header
  2019-10-24 14:44   ` Masahiro Yamada
@ 2019-10-25  6:12     ` Michal Simek
  0 siblings, 0 replies; 7+ messages in thread
From: Michal Simek @ 2019-10-25  6:12 UTC (permalink / raw)
  To: Masahiro Yamada, Michal Simek
  Cc: Linux Kernel Mailing List, git, Palmer Dabbelt,
	Christoph Hellwig, longman, Bjorn Helgaas, Paolo Bonzini,
	Arnd Bergmann, Jackie Liu, Wesley Terpstra, Firoz Khan,
	sparclinux, Ingo Molnar, Catalin Marinas, Ard Biesheuvel,
	linux-riscv, linux-arch, James Hogan, Vineet Gupta,
	Greg Kroah-Hartman, Ralf Baechle, Paul Walmsley,
	Peter Zijlstra (Intel),
	Will Deacon, Benjamin Herrenschmidt, Paul Burton, Cornelia Huck,
	Herbert Xu, Russell King, linux-arm-kernel, Albert Ou, arcml,
	David S. Miller, Eric Biggers, Michael Ellerman, linux-mips,
	Paul Mackerras, linuxppc-dev

On 24. 10. 19 16:44, Masahiro Yamada wrote:
> On Thu, Oct 24, 2019 at 7:13 PM Michal Simek <michal.simek@xilinx.com> wrote:
>>
>> msi.h is generic for all architectures expect of x86 which has own version.
> 
> Maybe a typo?  "except"

unfortunately yes.

> 
> 
> Anyway, the code looks good to me.
> 
> Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>

I have sent v2.
Who should be taking these patches?

Thanks,
Michal

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-10-25  6:12 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24 10:13 [PATCH 0/2] Enabling MSI for Microblaze Michal Simek
2019-10-24 10:13 ` [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header Michal Simek
2019-10-24 14:44   ` Masahiro Yamada
2019-10-25  6:12     ` Michal Simek
2019-10-24 15:17   ` Paul Walmsley
2019-10-24 10:13 ` [PATCH 2/2] pci: Default to PCI_MSI_IRQ_DOMAIN Michal Simek
2019-10-24 17:03 ` [PATCH 0/2] Enabling MSI for Microblaze Waiman Long

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).