From: Julia Lawall <julia.lawall@inria.fr>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kbuild-all@lists.01.org
Subject: [PATCH] usb: usbip: fix odd_ptr_err.cocci warnings
Date: Fri, 19 Feb 2021 18:10:10 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2102191807040.21109@hadrien> (raw)
From: kernel test robot <lkp@intel.com>
PTR_ERR should access the value just tested by IS_ERR
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://github.com/0day-ci/linux/commits/UPDATE-20210219-175233/Tetsuo-Handa/usb-usbip-serialize-attach-detach-operations/20210219-083847
head: 32963105fe23b600644ac10f0f9a42124a289990
commit: 32963105fe23b600644ac10f0f9a42124a289990 usb: usbip: serialize attach/detach operations
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
The above link doesn't work for me, so I don't know whether the goto label
is correct.
usbip_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/usbip/usbip_common.c
+++ b/drivers/usb/usbip/usbip_common.c
@@ -775,7 +775,7 @@ int usbip_prepare_threads(struct usbip_t
}
tx = kthread_create(tx_fn, ud, tx_name);
if (IS_ERR(tx)) {
- err = PTR_ERR(rx);
+ err = PTR_ERR(tx);
goto out_rx;
}
uti->tcp_socket = socket;
reply other threads:[~2021-02-19 17:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2102191807040.21109@hadrien \
--to=julia.lawall@inria.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=skhan@linuxfoundation.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).