* [PATCH] iommu: dart: fix call_kern.cocci warnings
@ 2021-04-04 15:26 Julia Lawall
2021-04-09 16:49 ` Sven Peter
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2021-04-04 15:26 UTC (permalink / raw)
To: Sven Peter
Cc: Marc Zyngier, Joerg Roedel, Will Deacon, iommu, linux-kernel,
linux-arm-kernel, kbuild-all
From: kernel test robot <lkp@intel.com>
Function apple_dart_attach_stream called on line 519 inside
lock on line 509 but uses GFP_KERNEL
Generated by: scripts/coccinelle/locks/call_kern.cocci
Fixes: ce67d3b3ef37 ("iommu: dart: Add DART iommu driver")
CC: Sven Peter <sven@svenpeter.dev>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git hack/m1-pcie
head: 1fd2c9634dd24fba323baba52200de18e4d3f4ee
commit: ce67d3b3ef3734925631ec65deb1cf8078d826cf [14/15] iommu: dart: Add DART iommu driver
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago
Please take the patch only if it's a positive warning. Thanks!
apple-dart-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/iommu/apple-dart-iommu.c
+++ b/drivers/iommu/apple-dart-iommu.c
@@ -435,7 +435,7 @@ static int apple_dart_attach_stream(stru
goto error;
}
- stream = kzalloc(sizeof(*stream), GFP_KERNEL);
+ stream = kzalloc(sizeof(*stream), GFP_ATOMIC);
if (!stream) {
ret = -ENOMEM;
goto error;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iommu: dart: fix call_kern.cocci warnings
2021-04-04 15:26 [PATCH] iommu: dart: fix call_kern.cocci warnings Julia Lawall
@ 2021-04-09 16:49 ` Sven Peter
0 siblings, 0 replies; 2+ messages in thread
From: Sven Peter @ 2021-04-09 16:49 UTC (permalink / raw)
To: Julia Lawall
Cc: Marc Zyngier, Joerg Roedel, Will Deacon, Petr Mladek via iommu,
linux-kernel, linux-arm-kernel, kbuild-all
On Sun, Apr 4, 2021, at 17:26, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
>
> Function apple_dart_attach_stream called on line 519 inside
> lock on line 509 but uses GFP_KERNEL
Thanks! Fixed for v3.
Best,
Sven
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-09 16:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-04 15:26 [PATCH] iommu: dart: fix call_kern.cocci warnings Julia Lawall
2021-04-09 16:49 ` Sven Peter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).