From: Julia Lawall <julia.lawall@inria.fr>
To: Mitali Borkar <mitaliborkar810@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com,
mitali_s@me.iitr.ac.in
Subject: Re: [Outreachy kernel] [PATCH v3 1/3] staging: rtl8192e: remove parentheses around boolean expression
Date: Sun, 11 Apr 2021 12:07:40 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2104111207000.2854@hadrien> (raw)
In-Reply-To: <30a330377667aa5043a60ed3cdf1bbb37099631c.1618133351.git.mitaliborkar810@gmail.com>
On Sun, 11 Apr 2021, Mitali Borkar wrote:
> Removed unnecessary parentheses around '!xyz' boolean expression as '!' has higher
> precedance than '||'
The log message is too wide. It should be at most around 70 characters
wide, because git will indent it a little.
julia
>
> Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> ---
>
> Changes from v2:- Modified subject description.
> Changes from v1:- Removed unnecessary parentheses around boolean expression.
> Changes has been made in v2.
>
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index b1fa8e9a4f28..431202927036 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -276,7 +276,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
> struct rt_hi_throughput *pHT = ieee->pHTInfo;
> struct ht_capab_ele *pCapELE = NULL;
>
> - if ((!posHTCap) || (!pHT)) {
> + if (!posHTCap || !pHT) {
> netdev_warn(ieee->dev,
> "%s(): posHTCap and pHTInfo are null\n", __func__);
> return;
> --
> 2.30.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/30a330377667aa5043a60ed3cdf1bbb37099631c.1618133351.git.mitaliborkar810%40gmail.com.
>
next prev parent reply other threads:[~2021-04-11 10:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-11 9:55 [PATCH v3 0/3] Modify subject description and rectify spelling mistake Mitali Borkar
2021-04-11 9:55 ` [PATCH v3 1/3] staging: rtl8192e: remove parentheses around boolean expression Mitali Borkar
2021-04-11 10:07 ` Julia Lawall [this message]
2021-04-11 9:55 ` [PATCH v3 2/3] staging: rtl8192e: remove unnecessary ftrace-like logging Mitali Borkar
2021-04-11 9:55 ` [PATCH v3 3/3] staging: rtl8192e: remove unnecessary parentheses Mitali Borkar
2021-04-12 9:34 ` [PATCH v3 0/3] Modify subject description and rectify spelling mistake Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2104111207000.2854@hadrien \
--to=julia.lawall@inria.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mitali_s@me.iitr.ac.in \
--cc=mitaliborkar810@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).