From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, TRACKER_ID,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87CCAC433ED for ; Thu, 15 Apr 2021 13:41:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58ADC611F1 for ; Thu, 15 Apr 2021 13:41:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233118AbhDONl7 (ORCPT ); Thu, 15 Apr 2021 09:41:59 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:11233 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230056AbhDONl6 (ORCPT ); Thu, 15 Apr 2021 09:41:58 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3AngYAza7UWSMWbtMJwAPXwCnXdLJzesId70hD?= =?us-ascii?q?6mlaTxtJfsuE0/2/hfhz726RtB89UGwt8OrqBICuWnXZnKQe3aAwOvOYUBDiqC?= =?us-ascii?q?+UKuhZjLfK5x3FN2nA+vVG1aFmGpIObeHYKVRhl8717E2ZPr8boOWvy6yjiefA?= =?us-ascii?q?w3oFd2gDV4ha4wh0EQqdGEFtLTM2ZqYRLoaW5cZMulObF0g/U8LTPBU4dtTYq8?= =?us-ascii?q?aOvJzrZgNuPW9E1CC+yQLt0rL8HhSCty1ybxpEy94ZnlT4rw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.82,225,1613430000"; d="scan'208";a="378762268" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 15:41:23 +0200 Date: Thu, 15 Apr 2021 15:41:23 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Mitali Borkar cc: zzam@gentoo.org, clabbe@baylibre.com, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in Subject: Re: [Outreachy kernel] Re: [PATCH v4 2/2] staging: media: zoran: add BIT() macro and align code In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > +#define ZR36057_JMC_JPG_EXP_MODE (0 << 29) > > > +#define ZR36057_JMC_JPG_CMP_MODE BIT(29) > > > +#define ZR36057_JMC_MJPG_EXP_MODE (2 << 29) > > > +#define ZR36057_JMC_MJPG_CMP_MODE (3 << 29) > > Same as above. Please change back ZR36057_JMC_JPG_CMP_MODE to be (1 << 29). > > Then this 2 bit field is consistent. > > > Sir, I guess this BIT(29) was already present. I didn't changed this. > I will change this as you said. It comes from this patch: 5e195bbddabdd94b15eeb60439cece996d58b329 Probably putting it back should be a different patch in the series. julia