* Makefile: make modules install output
@ 2021-06-09 10:15 Julia Lawall
2021-06-09 13:54 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2021-06-09 10:15 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kbuild, linux-kernel
make modules install used to end up with something like
INSTALL sound/usb/usx2y/snd-usb-usx2y.ko
INSTALL sound/x86/snd-hdmi-lpe-audio.ko
INSTALL sound/xen/snd_xen_front.ko
INSTALL virt/lib/irqbypass.ko
DEPMOD 5.12.0-rc2myfix-00015-gc6f886546cb8
From v5.13-rc1, it gives:
STRIP /lib/modules/5.13.0-rc1myfix/kernel/fs/btrfs/btrfs.ko
STRIP /lib/modules/5.13.0-rc1myfix/kernel/fs/xfs/xfs.ko
STRIP /lib/modules/5.13.0-rc1myfix/kernel/net/mac80211/mac80211.ko
STRIP /lib/modules/5.13.0-rc1myfix/kernel/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko
STRIP /lib/modules/5.13.0-rc1myfix/kernel/drivers/gpu/drm/amd/amdgpu/amdgpu.ko
DEPMOD /lib/modules/5.13.0-rc1myfix
Is the full path name considered to be an improvement? For the names of
the modules, it doesn't much matter, but the DEPMOD line was a convenient
way to get the full kernel name for subsequent rebooting.
thanks,
julia
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Makefile: make modules install output
2021-06-09 10:15 Makefile: make modules install output Julia Lawall
@ 2021-06-09 13:54 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2021-06-09 13:54 UTC (permalink / raw)
To: Julia Lawall; +Cc: Linux Kbuild mailing list, Linux Kernel Mailing List
On Wed, Jun 9, 2021 at 7:16 PM Julia Lawall <julia.lawall@inria.fr> wrote:
>
> make modules install used to end up with something like
>
> INSTALL sound/usb/usx2y/snd-usb-usx2y.ko
> INSTALL sound/x86/snd-hdmi-lpe-audio.ko
> INSTALL sound/xen/snd_xen_front.ko
> INSTALL virt/lib/irqbypass.ko
> DEPMOD 5.12.0-rc2myfix-00015-gc6f886546cb8
>
> From v5.13-rc1, it gives:
>
> STRIP /lib/modules/5.13.0-rc1myfix/kernel/fs/btrfs/btrfs.ko
> STRIP /lib/modules/5.13.0-rc1myfix/kernel/fs/xfs/xfs.ko
> STRIP /lib/modules/5.13.0-rc1myfix/kernel/net/mac80211/mac80211.ko
> STRIP /lib/modules/5.13.0-rc1myfix/kernel/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko
> STRIP /lib/modules/5.13.0-rc1myfix/kernel/drivers/gpu/drm/amd/amdgpu/amdgpu.ko
> DEPMOD /lib/modules/5.13.0-rc1myfix
>
> Is the full path name considered to be an improvement?
I think so.
It is clear where the files are being installed to.
Another motivation was rather to make it aligned with the convention.
Kbuild log convention is this form:
[ACTION] [DESTINATION]
For example, when Kbuild is building kernel/foo.c
into kernel/foo.o
CC kernel/foo.o
is shown.
In this case, Kbuild is installing kernel/fs/btrfs/btrfs.ko
to /lib/modules/5.13.0-rc1myfix/kernel/fs/btrfs/btrfs.ko
So, I think it is more consistent to show the destination
rather than the source.
> For the names of
> the modules, it doesn't much matter, but the DEPMOD line was a convenient
> way to get the full kernel name for subsequent rebooting.
>
> thanks,
> julia
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-09 13:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 10:15 Makefile: make modules install output Julia Lawall
2021-06-09 13:54 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).