From: Julia Lawall <julia.lawall@inria.fr>
To: Denis Efremov <efremov@linux.com>
Cc: Keith Busch <kbusch@kernel.org>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] coccinelle: api: remove kobj_to_dev.cocci script
Date: Mon, 21 Jun 2021 20:47:38 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2106212047100.47043@hadrien> (raw)
In-Reply-To: <cc3b2db6-70fd-0bb2-d083-f87f9a35e9a7@linux.com>
On Mon, 21 Jun 2021, Denis Efremov wrote:
>
>
> On 6/21/21 8:48 PM, Keith Busch wrote:
> > Using kobj_to_dev() instead of container_of() is not universally
> > accepted among maintainers as an improvement. The warning leads to
> > repeated patch submissions that won't be accepted. Remove the script.
> >
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Jens Axboe <axboe@kernel.dk>
> > Cc: Denis Efremov <efremov@linux.com>
> > Cc: Julia Lawall <Julia.Lawall@inria.fr>
> > Signed-off-by: Keith Busch <kbusch@kernel.org>
>
> Acked-by: Denis Efremov <efremov@linux.com>
Applied.
>
> > ---
> > scripts/coccinelle/api/kobj_to_dev.cocci | 45 ------------------------
> > 1 file changed, 45 deletions(-)
> > delete mode 100644 scripts/coccinelle/api/kobj_to_dev.cocci
> >
> > diff --git a/scripts/coccinelle/api/kobj_to_dev.cocci b/scripts/coccinelle/api/kobj_to_dev.cocci
> > deleted file mode 100644
> > index cd5d31c6fe76..000000000000
> > --- a/scripts/coccinelle/api/kobj_to_dev.cocci
> > +++ /dev/null
> > @@ -1,45 +0,0 @@
> > -// SPDX-License-Identifier: GPL-2.0-only
> > -///
> > -/// Use kobj_to_dev() instead of container_of()
> > -///
> > -// Confidence: High
> > -// Copyright: (C) 2020 Denis Efremov ISPRAS
> > -// Options: --no-includes --include-headers
> > -//
> > -// Keywords: kobj_to_dev, container_of
> > -//
> > -
> > -virtual context
> > -virtual report
> > -virtual org
> > -virtual patch
> > -
> > -
> > -@r depends on !patch@
> > -expression ptr;
> > -symbol kobj;
> > -position p;
> > -@@
> > -
> > -* container_of(ptr, struct device, kobj)@p
> > -
> > -
> > -@depends on patch@
> > -expression ptr;
> > -@@
> > -
> > -- container_of(ptr, struct device, kobj)
> > -+ kobj_to_dev(ptr)
> > -
> > -
> > -@script:python depends on report@
> > -p << r.p;
> > -@@
> > -
> > -coccilib.report.print_report(p[0], "WARNING opportunity for kobj_to_dev()")
> > -
> > -@script:python depends on org@
> > -p << r.p;
> > -@@
> > -
> > -coccilib.org.print_todo(p[0], "WARNING opportunity for kobj_to_dev()")
> >
>
next prev parent reply other threads:[~2021-06-21 18:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 17:48 [PATCH] coccinelle: api: remove kobj_to_dev.cocci script Keith Busch
2021-06-21 18:32 ` Denis Efremov
2021-06-21 18:47 ` Julia Lawall [this message]
2021-06-21 18:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2106212047100.47043@hadrien \
--to=julia.lawall@inria.fr \
--cc=axboe@kernel.dk \
--cc=efremov@linux.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).