From: Julia Lawall <julia.lawall@inria.fr>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Kees Cook <keescook@chromium.org>,
cocci@inria.fr, Linus Torvalds <torvalds@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
mm-commits@vger.kernel.org, masahiroy@kernel.org,
gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [cocci] [PATCH -mm] -funsigned-char, x86: make struct p4_event_bind::cntr signed array
Date: Thu, 3 Nov 2022 07:31:47 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2211030726351.2877@hadrien> (raw)
In-Reply-To: <Y2MGlTwh9aB+4z4l@zx2c4.com>
On Thu, 3 Nov 2022, Jason A. Donenfeld wrote:
> On Wed, Nov 02, 2022 at 06:17:04PM +0100, Julia Lawall wrote:
> >
> >
> > On Wed, 26 Oct 2022, Jason A. Donenfeld wrote:
> >
> > > On Wed, Oct 26, 2022 at 03:50:25AM +0200, Jason A. Donenfeld wrote:
> > > > The traditional objdump comparison does work, though. It produces a good
> > >
> > > Another thing that appears to work well is just using Coccinelle
> > > scripts. I've had some success just scrolling through the results of:
> > >
> > > @@
> > > char c;
> > > expression E;
> > > @@
> > > (
> > > * E > c
> > > |
> > > * E >= c
> > > |
> > > * E < c
> > > |
> > > * E <= c
> > > )
> > >
> > > That also triggers on explicitly signed chars, and examining those
> > > reveals that quite a bit of code in the tree already does do the right
> > > thing, which is good.
> > >
> > > From looking at this and objdump output, it looks like most naked-char
> > > usage that isn't for strings is actually already assuming it's unsigned,
> > > using it as a byte. I'll continue to churn, and I'm sure I'll miss a few
> > > things here and there, but all and all, I don't think this is looking as
> > > terrible as I initially feared.
> > >
> > > I'm CC'ing the Coccinelle people to see if they have any nice ideas on
> > > improvements. Specifically, the thing we're trying to identify is:
> > >
> > > - Usage of vanilla `char`, without a `signed` or `unsigned` qualifier,
> > > where:
> >
> > Try putting
> >
> > disable optional_qualifier
> >
> > between the initial @@, to avoid the implicit matching of signed and
> > unsigned.
>
> Hmm, this doesn't quite work. Here are my rules:
>
> @disable optional_qualifier@
> char c;
> expression E;
> @@
> (
> * E > c
> |
> * E >= c
> |
> * E < c
> |
> * E <= c
> )
>
> @disable optional_qualifier@
> char c;
> @@
> * c == -1
>
> @disable optional_qualifier@
> char c;
> @@
> * c = -1
>
> This produces, for example:
>
> diff -u -p ./sound/firewire/bebob/bebob_focusrite.c /tmp/nothing/sound/firewire/bebob/bebob_focusrite.c
> --- ./sound/firewire/bebob/bebob_focusrite.c
> +++ /tmp/nothing/sound/firewire/bebob/bebob_focusrite.c
> @@ -192,7 +192,6 @@ saffirepro_both_clk_src_get(struct snd_b
>
> /* In a case that this driver cannot handle the value of register. */
> value &= SAFFIREPRO_CLOCK_SOURCE_SELECT_MASK;
> - if (value >= SAFFIREPRO_CLOCK_SOURCE_COUNT || map[value] < 0) {
> err = -EIO;
> goto end;
> }
>
> Except map is defined as:
>
> const signed char *map;
>
> So this would be one of those cases that I had hoped `disable
> optional_qualifier` would exclude. (I think internally coccinelle might
> be assuming `char` is signed, by the way.)
OK, I see the problem. Coccinelle isn't taking the "disable
optional_qualifier" into account when it checks types on expressions. It
would work if you put, eg:
char x;
... when any
* x < 0
But that would be much slower and less general. I will fix it.
>
> > > - It's not being used for characters; and
> > > - It's doing something that assumes it is signed, such as various
> > > types of comparisons or decrements.
> >
> > I took a quick look at the article, but I'm not completely sure what you
> > are getting at here. Could you give some examples of what you do and
> > don't want to find?
> >
> > You don't want the case where c is 'x', for some x?
>
> Something I would want to find is `if (c < 0)`. Something I wouldn't
> want to find is `if (c < '9')`. IOW, I'm looking for code that assumes
> `c` is signed, and would become incorrect if `c` suddenly became
> unsigned. Most things involving actual characters are fine. But most
> things involving signed arithmetic or comparisons with numbers isn't
> find.
This seems to do what you want:
@disable optional_qualifier@
constant char cc;
expression e;
char c;
@@
(
c < cc
|
* c < e
)
It highlights only the two return lines in:
int main () {
char x;
if (x < 'd')
return x < 0;
else return x < y;
}
julia
>
> Jason
>
next prev parent reply other threads:[~2022-11-03 6:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221020000356.177CDC433C1@smtp.kernel.org>
2022-10-20 9:43 ` + kbuild-treat-char-as-always-unsigned.patch added to mm-nonmm-unstable branch Alexey Dobriyan
2022-10-20 9:49 ` [PATCH -mm] -funsigned-char, x86: make struct p4_event_bind::cntr signed array Alexey Dobriyan
2022-10-20 9:56 ` [PATCH -mm] -funsigned-char, namei: delete cast in lookup_one_common() Alexey Dobriyan
2022-10-20 16:28 ` [PATCH -mm] -funsigned-char, x86: make struct p4_event_bind::cntr signed array Jason A. Donenfeld
2022-10-20 17:14 ` Linus Torvalds
2022-10-20 17:33 ` Jason A. Donenfeld
2022-10-20 17:42 ` Linus Torvalds
2022-10-20 18:57 ` Kees Cook
2022-10-20 19:39 ` Linus Torvalds
2022-10-20 20:17 ` Linus Torvalds
2022-10-20 21:34 ` Andy Shevchenko
2022-10-20 22:46 ` Jason A. Donenfeld
2022-10-21 6:48 ` Greg KH
2022-10-21 7:24 ` Jason A. Donenfeld
2022-10-21 7:36 ` Greg KH
2022-10-26 1:50 ` Jason A. Donenfeld
2022-10-26 12:58 ` Jason A. Donenfeld
2022-10-26 13:17 ` Andy Shevchenko
2022-11-02 17:17 ` [cocci] " Julia Lawall
2022-11-03 0:08 ` Jason A. Donenfeld
2022-11-03 6:31 ` Julia Lawall [this message]
2022-11-03 12:45 ` Julia Lawall
2022-11-03 12:47 ` Jason A. Donenfeld
2022-11-03 12:57 ` Julia Lawall
2022-11-03 14:07 ` Jason A. Donenfeld
2022-10-24 15:44 ` Jason A. Donenfeld
2022-10-21 5:59 ` Alexey Dobriyan
2022-10-21 17:11 ` Linus Torvalds
2022-10-21 17:23 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2211030726351.2877@hadrien \
--to=julia.lawall@inria.fr \
--cc=Jason@zx2c4.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cocci@inria.fr \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).