From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Alsa-devel <alsa-devel@alsa-project.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v5] ASoC: SOF: Fix deadlock when shutdown a frozen userspace
Date: Mon, 28 Nov 2022 16:41:33 +0200 (EET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2211281629120.3532114@eliteleevi.tm.intel.com> (raw)
In-Reply-To: <20221127-snd-freeze-v5-0-4ededeb08ba0@chromium.org>
Hi,
On Mon, 28 Nov 2022, Ricardo Ribalda wrote:
> During kexec(), the userspace is frozen. Therefore we cannot wait for it
> to complete.
>
> Avoid running snd_sof_machine_unregister during shutdown.
[...]
> /*
> - * make sure clients and machine driver(s) are unregistered to force
> - * all userspace devices to be closed prior to the DSP shutdown sequence
> + * make sure clients are unregistered prior to the DSP shutdown
> + * sequence.
> */
> sof_unregister_clients(sdev);
>
> - snd_sof_machine_unregister(sdev, pdata);
> -
> if (sdev->fw_state == SOF_FW_BOOT_COMPLETE)
this is problematic as removing that machine_unregister() call will (at
least) bring back an issue on Intel platforms (rare problem hitting S5 on
Chromebooks).
Not sure how to solve this, but if that call needs to be removed
(unsafe to call at shutdown), then we need to rework how SOF
does the cleanup.
Br, Kai
next prev parent reply other threads:[~2022-11-28 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 13:51 [PATCH v5] ASoC: SOF: Fix deadlock when shutdown a frozen userspace Ricardo Ribalda
2022-11-28 14:41 ` Kai Vehmanen [this message]
2022-11-28 17:10 ` Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2211281629120.3532114@eliteleevi.tm.intel.com \
--to=kai.vehmanen@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=ribalda@chromium.org \
--cc=sound-open-firmware@alsa-project.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).