linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Cerveny <martin@c-home.cz>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Maxime Ripard <maxime@cerno.tech>,
	Martin Cerveny <m.cerveny@computer.org>,
	Chen-Yu Tsai <wens@csie.org>,
	"David S. Miller" <davem@davemloft.net>,
	devicetree@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-arm-kernel@lists.infradead.org,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: crypto: add new compatible for V3s
Date: Sat, 5 Sep 2020 17:51:48 +0200 (CEST)	[thread overview]
Message-ID: <alpine.GSO.2.00.2009051749080.3102@dmz.c-home.cz> (raw)
In-Reply-To: <20200902062824.GA17544@Red>


On Wed, 2 Sep 2020, Corentin Labbe wrote:
> On Tue, Sep 01, 2020 at 01:40:15PM +0200, Maxime Ripard wrote:
>> On Tue, Sep 01, 2020 at 12:57:19PM +0200, Corentin Labbe wrote:
>>> On Tue, Sep 01, 2020 at 11:32:49AM +0200, Maxime Ripard wrote:
>>>> On Mon, Aug 31, 2020 at 09:30:59AM +0200, Martin Cerveny wrote:
>>>>> Like A33 "sun4i-ss" has a difference, it give SHA1 digest
>>>>> directly in BE. So add new compatible.
>>>>>
>>>>> Tested-by: Martin Cerveny <m.cerveny@computer.org>
>>>>
>>>> The Tested-by tag is for the other developpers. You're very much
>>>> expected to have tested your patch before contributing it.
>>>>
>>>>> Signed-off-by: Martin Cerveny <m.cerveny@computer.org>
>>>>> ---
>>>>>  .../bindings/crypto/allwinner,sun4i-a10-crypto.yaml          | 5 ++++-
>>>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
>>>>> index fc823572b..180efd13a 100644
>>>>> --- a/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
>>>>> +++ b/Documentation/devicetree/bindings/crypto/allwinner,sun4i-a10-crypto.yaml
>>>>> @@ -25,6 +25,7 @@ properties:
>>>>>            - const: allwinner,sun4i-a10-crypto
>>>>>        - items:
>>>>>            - const: allwinner,sun8i-a33-crypto
>>>>> +      - const: allwinner,sun8i-v3s-crypto
>>>>
>>>> If it's compatible with the A33, why do we need to introduce a new compatible?
>>>>
>>>>>
>>>>>    reg:
>>>>>      maxItems: 1
>>>>> @@ -59,7 +60,9 @@ if:
>>>>>    properties:
>>>>>      compatible:
>>>>>        contains:
>>>>> -        const: allwinner,sun6i-a31-crypto
>>>>> +        oneOf:
>>>>> +          - const: allwinner,sun6i-a31-crypto
>>>>> +          - const: allwinner,sun8i-v3s-crypto
>>>>
>>>> I guess the A33 compatible should be on that list as well?
>>>
>>> This is the list of "need reset".
>>> So we cannot use allwinner,sun8i-a33-crypto
>>> Probably this explanation should be in the commit message.
>>
>> But the A33 has a reset in the DTSI
>>
>
>
> Oh right so I need to send a fix for that and Martin Cerveny could simply use the "allwinner,sun8i-a33-crypto" (and so keep only patch #1(DTS))
>
> Regards
>

What is "right" solution for DTSI ?
- compatible = "allwinner,sun8i-a33-crypto";
OR
- compatible = "allwinner,sun8i-v3s-crypto", "allwinner,sun8i-a33-crypto";
(but unimplemented "allwinner,sun8i-v3s-crypto")

Regards

  reply	other threads:[~2020-09-05 16:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31  7:30 [PATCH v2 0/3] crypto: sun4i-ss: add support for V3s Martin Cerveny
2020-08-31  7:30 ` [PATCH v2 1/3] dt-bindings: crypto: add new compatible " Martin Cerveny
2020-09-01  9:32   ` Maxime Ripard
2020-09-01 10:57     ` Corentin Labbe
2020-09-01 11:40       ` Maxime Ripard
2020-09-02  6:28         ` Corentin Labbe
2020-09-05 15:51           ` Martin Cerveny [this message]
2020-09-14 18:24             ` Rob Herring
2020-08-31  7:31 ` [PATCH v2 2/3] ARM: dts: sun8i: v3s: Enable crypto engine Martin Cerveny
2020-09-01  9:33   ` Maxime Ripard
2020-08-31  7:31 ` [PATCH v2 3/3] crypto: sun4i-ss - add the V3s variant of SS Martin Cerveny
2020-08-31 11:50   ` Corentin Labbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.GSO.2.00.2009051749080.3102@dmz.c-home.cz \
    --to=martin@c-home.cz \
    --cc=clabbe.montjoie@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.cerveny@computer.org \
    --cc=maxime@cerno.tech \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).