From: Len Brown <lenb@kernel.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
"Moore, Robert" <robert.moore@intel.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Oops in ACPI with git latest
Date: Fri, 24 Oct 2008 16:42:29 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0810241642240.3056@localhost.localdomain> (raw)
In-Reply-To: <200810242150.31809.rjw@sisk.pl>
applied.
thanks,
-len
On Fri, 24 Oct 2008, Rafael J. Wysocki wrote:
> On Friday, 24 of October 2008, Jesse Barnes wrote:
> > On Friday, October 24, 2008 11:43 am Rafael J. Wysocki wrote:
> > > On Friday, 24 of October 2008, Jesse Barnes wrote:
> > > > So who wants to send me a final patch for this?
> > >
> > > I already did: http://marc.info/?l=linux-kernel&m=122484871717023&w=4
> > > but I can remove the "!output.pointer || " if you prefer. :-)
> >
> > Yeah Bob said it would likely contain garbage anyway, so we should just remove
> > it.
>
> OK, here you go.
>
> ---
> From: Rafael J. Wysocki <rjw@sisk.pl>
> Subject: Prevent acpi_run_osc from using NULL objects
>
> Check if the object returned by acpi_evaluate_object() in
> acpi_run_osc() is not NULL before using it.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/pci/pci-acpi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: linux-2.6/drivers/pci/pci-acpi.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/pci-acpi.c
> +++ linux-2.6/drivers/pci/pci-acpi.c
> @@ -83,6 +83,9 @@ static acpi_status acpi_run_osc(acpi_han
> if (ACPI_FAILURE(status))
> return status;
>
> + if (!output.length)
> + return AE_NULL_OBJECT;
> +
> out_obj = output.pointer;
> if (out_obj->type != ACPI_TYPE_BUFFER) {
> printk(KERN_DEBUG "Evaluate _OSC returns wrong type\n");
>
next prev parent reply other threads:[~2008-10-24 20:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 19:45 Oops in ACPI with git latest James Bottomley
2008-10-23 20:42 ` Rafael J. Wysocki
2008-10-23 22:34 ` Moore, Robert
2008-10-24 1:27 ` James Bottomley
2008-10-24 6:57 ` Rafael J. Wysocki
2008-10-24 11:49 ` [PATCH] Subject: Prevent acpi_run_osc from using NULL objects (was: Re: Oops in ACPI with git latest) Rafael J. Wysocki
2008-10-24 15:02 ` Moore, Robert
2008-10-24 20:27 ` Len Brown
2008-10-24 20:43 ` Moore, Robert
2008-10-24 14:57 ` Oops in ACPI with git latest Moore, Robert
2008-10-24 18:04 ` Jesse Barnes
2008-10-24 18:43 ` Rafael J. Wysocki
2008-10-24 19:22 ` Jesse Barnes
2008-10-24 19:50 ` Rafael J. Wysocki
2008-10-24 20:42 ` Len Brown [this message]
2008-10-24 1:17 ` James Bottomley
2008-10-24 6:47 ` Rafael J. Wysocki
2008-10-24 15:04 ` Moore, Robert
2008-10-24 1:17 ` Lin Ming
2008-10-24 15:37 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0810241642240.3056@localhost.localdomain \
--to=lenb@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).