From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758049AbZCBXgZ (ORCPT ); Mon, 2 Mar 2009 18:36:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754706AbZCBXgQ (ORCPT ); Mon, 2 Mar 2009 18:36:16 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:54480 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753898AbZCBXgP (ORCPT ); Mon, 2 Mar 2009 18:36:15 -0500 Date: Mon, 2 Mar 2009 15:35:09 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: =?ISO-8859-15?Q?Arve_Hj=F8nnev=E5g?= cc: "Rafael J. Wysocki" , LKML , Ingo Molnar , "Eric W. Biederman" , Benjamin Herrenschmidt , Jeremy Fitzhardinge , pm list , Len Brown , Jesse Barnes , Thomas Gleixner , Alan Stern , Johannes Berg Subject: Re: [RFC][PATCH 1/4] PM: Rework handling of interrupts during suspend-resume (rev. 4) In-Reply-To: Message-ID: References: <200902221837.49396.rjw@sisk.pl> <200903012324.39327.rjw@sisk.pl> <200903030013.02805.rjw@sisk.pl> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Mar 2009, Linus Torvalds wrote: > > If IRQ_SUSPENDED _is_ set, then that means that we're after the > suspend_late() sequence and before the resume_early() sequence Sorry, after the suspend, and before the resume. We could be _in_ the suspend_late/resume_early sequence, but a driver that were to try to play with interrupts at that stage would be broken. It can't very well do a enable_irq(), because that would be a MAJOR BUG - it would make the whole irq suspend thing pointless, since now interrupts would start to happen exactly where they must not happen! Linus