linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>,
	randy.dunlap@oracle.com, akpm@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/10] MAINTAINERS - add script, patterns and misc updates
Date: Fri, 17 Apr 2009 14:58:15 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.0904171446500.4042@localhost.localdomain> (raw)
In-Reply-To: <20090417144117.4ac8828f.akpm@linux-foundation.org>



On Fri, 17 Apr 2009, Andrew Morton wrote:
> 
> : fatal: Not a git repository
> 
>     it whines about not being run in a git directory, but does a decent
>     job anyway.  

The default options are: --email --git --m --l --multiline, and the 
"--git" part basically does a

	git log --since=${email_git_since} -- ${file}

to see the logs, and greps and counts sign-offs.

So the "fatal: Not a git repository" is from git saying it can't do that.

And as a result, it _only_ looks at your MAINTAINERS file, rather than 
trying to figure it out from other sources too.

For example:

	[torvalds@nehalem linux]$ ./scripts/get_maintainer.pl --no-git -f kernel/exit.c
	linux-kernel@vger.kernel.org

would be what you see. And then if you have git, you'd also see

	[torvalds@nehalem linux]$ ./scripts/get_maintainer.pl --git -f kernel/exit.c
	Andrew Morton <akpm@linux-foundation.org>
	Ingo Molnar <mingo@elte.hu>
	Oleg Nesterov <oleg@tv-sign.ru>
	Oleg Nesterov <oleg@redhat.com>
	Roland McGrath <roland@redhat.com>

because it literally looked at sign-offs of patches that touched 
kernel/exit.c in the last year, and noticed that those tive people had the 
top five spots.

(Ok, so I have the top spot, but I'm a penguin chief and as such get 
excused. You were _originally_ on that list too, but apparently you like 
getting email, so now you're listed too).

And yeah, I personally find the git statistics more relevant than the 
MAINTAINERS list. I just tend to do it by hand, although I tend to use a 
six-month cutoff:

	git log --since=6.months.ago kernel/exit.c |
		grep 'Signed-off-by: ' |
		sort | uniq -c | sort -n

works beautifully on just about any set of files and doesn't need no 
steenking perl.

		Linus


  reply	other threads:[~2009-04-17 22:03 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-08  5:17 [PATCH 0/10] MAINTAINERS - add script, patterns and misc updates Joe Perches
2009-04-08  5:17 ` [PATCH 01/10] Add scripts/get_maintainer.pl Joe Perches
2009-04-08  5:17 ` [PATCH 02/10] MAINTAINERS - Add file patterns Joe Perches
2009-04-08  6:59   ` Geert Uytterhoeven
2009-04-08 15:44     ` Joe Perches
2009-04-08 14:13   ` Mauro Carvalho Chehab
2009-04-08 15:35     ` Joe Perches
2009-04-17  4:45       ` Mauro Carvalho Chehab
2009-04-08 16:51   ` Greg KH
2009-04-08 17:07     ` Joe Perches
2009-04-08 17:11       ` Greg KH
2009-04-09 15:42   ` Timur Tabi
2009-04-09 17:42     ` Joe Perches
2009-04-09 17:44       ` Timur Tabi
2009-04-08  5:17 ` [PATCH 03/10] MAINTAINERS - Standardize style Joe Perches
2009-04-08  5:17 ` [PATCH 04/10] MAINTAINERS - Remove HP Fibre Channel HBA no longer in tree Joe Perches
2009-04-08  5:17 ` [PATCH 05/10] MAINTAINERS - standardize "T: git urls" Joe Perches
2009-04-08  5:17 ` [PATCH 06/10] MAINTAINERS - Add Linus Torvalds' git Joe Perches
2009-04-08  5:17 ` [PATCH 07/10] MAINTAINERS - i2c_tiny_usb T: should be W: Joe Perches
2009-04-08  5:17 ` [PATCH 08/10] MAINTAINERS - Update FPU Emulator contact address and web page Joe Perches
2009-04-08  5:17 ` [PATCH 09/10] MAINTAINERS - Remove x86/Voyager no longer in tree Joe Perches
2009-04-08  5:17 ` [PATCH 10/10] MAINTAINERS - Remove cyblafb frame buffer " Joe Perches
2009-04-17 20:47 ` [PATCH 0/10] MAINTAINERS - add script, patterns and misc updates Randy Dunlap
2009-04-17 21:27   ` Joe Perches
2009-04-07  8:13     ` Pavel Machek
2009-04-22 15:54       ` Joe Perches
2009-04-22 18:59         ` Sam Ravnborg
2009-04-22 19:05           ` Andrew Morton
2009-04-22 19:56             ` Joe Perches
2009-04-22 20:30               ` Pavel Machek
2009-04-22 20:34                 ` Joe Perches
2009-04-24  7:13                 ` Joe Perches
2009-05-10 20:26                   ` RFC: MAINTAINER email address style? Joe Perches
2009-05-10 20:53                     ` Sam Ravnborg
2009-05-10 21:00                       ` Joe Perches
2009-05-10 21:09                         ` Sam Ravnborg
2009-05-10 21:45                           ` Bartlomiej Zolnierkiewicz
2009-05-11  1:37                             ` KOSAKI Motohiro
2009-05-11  0:48                       ` Andrew Morton
2009-05-10 21:22                     ` Pavel Machek
2009-05-10 21:24                     ` Alan Cox
2009-05-10 21:36                       ` Pavel Machek
2009-05-10 22:46                         ` Alan Cox
2009-05-10 21:52                       ` Joe Perches
2009-05-10 22:04                         ` Alan Cox
2009-05-10 22:35                           ` Joe Perches
2009-05-13  0:03                     ` [GIT PULL] MAINTAINERS, scripts/get_maintainer.pl, and Documentation/SubmittingPatches Joe Perches
2009-04-17 21:30     ` [PATCH 0/10] MAINTAINERS - add script, patterns and misc updates Randy Dunlap
2009-04-17 21:41     ` Andrew Morton
2009-04-17 21:58       ` Linus Torvalds [this message]
2009-04-17 22:09       ` Joe Perches
2009-04-17 22:18         ` Andrew Morton
2009-04-17 22:53           ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0904171446500.4042@localhost.localdomain \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).