Re: -tip: origin tree boot crash

From: Len Brown <lenb@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Matthew Garrett <mjg@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: -tip: origin tree boot crash
Date: Sat, 26 Dec 2009 15:19:10 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0912261518400.4089@localhost.localdomain> (raw)
In-Reply-To: <20091225194935.GA23802@core.coreip.homeip.net>

> dell-wmi - fix condition to abort driver loading


applied to acpi-test

thanks,
-Len Brown, Intel Open Source Technology Center

> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> The commit 1fdd407f4e3f2ecb453954cbebb6c22491c61853 incorrectly made driver
> abort loading when known GUID is present when it should have done exactly
> the opposite.
> 
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> ---
> 
>  drivers/platform/x86/dell-wmi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 916ccb2..c980782 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -324,7 +324,7 @@ static int __init dell_wmi_init(void)
>  {
>  	int err;
>  
> -	if (wmi_has_guid(DELL_EVENT_GUID)) {
> +	if (!wmi_has_guid(DELL_EVENT_GUID)) {
>  		printk(KERN_WARNING "dell-wmi: No known WMI GUID found\n");
>  		return -ENODEV;
>  	}
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>