From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755976Ab0AFRdh (ORCPT ); Wed, 6 Jan 2010 12:33:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755942Ab0AFRdc (ORCPT ); Wed, 6 Jan 2010 12:33:32 -0500 Received: from casper.infradead.org ([85.118.1.10]:48603 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755055Ab0AFRd3 (ORCPT ); Wed, 6 Jan 2010 12:33:29 -0500 Date: Wed, 6 Jan 2010 17:33:17 +0000 (GMT) From: James Simmons To: Johan Hovold cc: Dave Airlie , dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/kms: fix fbdev blanking regression In-Reply-To: <1262797226-9593-2-git-send-email-jhovold@gmail.com> Message-ID: References: <1262797226-9593-1-git-send-email-jhovold@gmail.com> <1262797226-9593-2-git-send-email-jhovold@gmail.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Commit 731b5a15a3b1474a41c2ca29b4c32b0f21bc852e (drm/kms: properly > handle fbdev blanking) breaks console blanking on my laptop (GM45 > chipset). Instead of blanking the screen, it is dimmed and then the > backlight starts "glowing" in the lower edges of the screen. The glowing > then slowly spreads upwards. Does not look healthy at all... > > This patch reverts to the old behaviour of going directly to > DPMS_STANDBY. The current fbdev blank is correct. Normal blanking doesn't power down the hsync or the vsync signals. If you look at fbdev drivers you will see this type of behavior. If you want a full power down then a FB_BLANK_POWERDOWN is needed. As for the blacklight that is a another problem not related to this issue. The fbdev layer sends a event to the backlight layer to tell it to power down. That powerdown happens for the backlight in all cases except FB_BLANK_UNBLANK. How is your backlight setup. Is the backlight handled via the DRI driver or acpi? > Signed-off-by: Johan Hovold > --- > drivers/gpu/drm/drm_fb_helper.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 1b49fa0..9008583 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -389,7 +389,7 @@ int drm_fb_helper_blank(int blank, struct fb_info *info) > break; > /* Display: Off; HSync: On, VSync: On */ > case FB_BLANK_NORMAL: > - drm_fb_helper_off(info, DRM_MODE_DPMS_ON); > + drm_fb_helper_off(info, DRM_MODE_DPMS_STANDBY); > break; > /* Display: Off; HSync: Off, VSync: On */ > case FB_BLANK_HSYNC_SUSPEND: > -- > 1.6.6 > >