From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755481Ab0APQCe (ORCPT ); Sat, 16 Jan 2010 11:02:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754646Ab0APQCd (ORCPT ); Sat, 16 Jan 2010 11:02:33 -0500 Received: from casper.infradead.org ([85.118.1.10]:59294 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754461Ab0APQCd (ORCPT ); Sat, 16 Jan 2010 11:02:33 -0500 Date: Sat, 16 Jan 2010 16:02:21 +0000 (GMT) From: James Simmons To: Jesse Barnes cc: David John , Johan Hovold , Dave Airlie , dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Eric Anholt Subject: Re: [PATCH] drm/kms: fix fbdev blanking regression In-Reply-To: <20100112093454.57176b8c@jbarnes-piketon> Message-ID: References: <1262797226-9593-1-git-send-email-jhovold@gmail.com> <1262797226-9593-2-git-send-email-jhovold@gmail.com> <20100106180950.GD10442@localhost> <20100106191234.GE10442@localhost> <4B458209.2030600@xenontk.org> <20100112093454.57176b8c@jbarnes-piketon> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > On 01/07/2010 12:42 AM, Johan Hovold wrote: > > > >> Yeap. The fix uncovered a bug in your driver. I haven't heard of > > > >> problems with the other drm drivers. > > > >> > > > >>> The backlight is handled via the DRI driver I assume. At least > > > >>> i9xx_crtc_dpms is called on powerdown. > > > >> > > > >> Can you post your dmesg and kernel config. > > > > > > [snip] > > > > > > Adding the Intel DRM people in CC as well. I have the same issue > > > with my GM45. > > > > Okay I looked at the code to figure out what is happening and why > > only this driver has problems. The problem is that the framebuffer > > layer expects the backlight to be a seperate device. The reason being > > is that some embedded systems will use a gpio backlight. That way > > power management for a graphics card/backlight has 3 seperate states. > > Currently the intel DRM driver treats the backlight as being apart of > > the encoder. Jesse do you have objections to having the intel driver > > expose a backlight device. The bonus of that is the user can also set > > the backlight levels. > > On Intel we usually expect the backlight to be exposed by ACPI or a > platform driver. On recent platforms, the ACPI driver will actually > send requests to the gfx driver to do the actual register writes to > adjust the backlight, but it's still ACPI driven. > > Maybe we just need to wire up the fb backlight hooks appropriately? I'm about to work up a patch And I noticed that drm-next and drm-intel-next are very different. Which tree should I use? Second is it possible for a card to support more than one backlight.