From: Len Brown <lenb@kernel.org>
To: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Rakib Mullick <rakib.mullick@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] acpi: Fix unused variable warning in sbs.c
Date: Sat, 16 Jan 2010 16:03:03 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1001161602070.7124@localhost.localdomain> (raw)
In-Reply-To: <4B488CFA.2070304@suse.de>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 488 bytes --]
On Sat, 9 Jan 2010, Alexey Starikovskiy wrote:
> Andrew Morton пишет:
> > I wonder if it can be fixed in Kconfig. Is there any sane use of
> > this code when CONFIG_ACPI_SYSFS_POWER=n && CONFIG_ACPI_PROCFS_POWER=n?
> No, this driver is useless in such a case. It can not output any info (and this is all it does).
Hi Alex,
Probably the code can lose some ifdefs by doing things
like making acpi_battery_remove_fs() a static inline when
!CONFIG_ACPI_PROCFS_POWER.
cheers,
-Len
prev parent reply other threads:[~2010-01-16 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-03 13:27 [PATCH] acpi: Fix unused variable warning in sbs.c Rakib Mullick
2010-01-07 22:51 ` Andrew Morton
2010-01-08 7:04 ` Rakib Mullick
2010-01-09 14:04 ` Alexey Starikovskiy
2010-01-16 21:03 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1001161602070.7124@localhost.localdomain \
--to=lenb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=astarikovskiy@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).