From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752702Ab0BVRCJ (ORCPT ); Mon, 22 Feb 2010 12:02:09 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:34694 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752297Ab0BVRCH (ORCPT ); Mon, 22 Feb 2010 12:02:07 -0500 Date: Mon, 22 Feb 2010 09:01:39 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Ingo Molnar cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Paul Mackerras , Thomas Gleixner , Fr??d??ric Weisbecker , Andrew Morton , "H. Peter Anvin" Subject: Re: [GIT PULL] perf fixes In-Reply-To: <20100222165052.GA14352@elte.hu> Message-ID: References: <20100222165052.GA14352@elte.hu> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Feb 2010, Ingo Molnar wrote: > > The reason i'm sending them post -rc8 is the fix for the Wine breakage from > Frederic, which would be nice to see resolved in -final. Umm. That commit seems to be crap. Yes, it was wrong to not allow a NULL address breakpoint. But if you call kallsyms_lookup_name(), you should check the "I couldn't find it" end result for _that_ case, and 0 is the correct check there. So the code _should_ do something like if (info->name) { info->address = kallsyms_lookup_name(info->name); if (!info->address) return -EINVAL; } and that would correctly handle both the NULL original address _and_ the name lookup failure. Also, note how I removed the totally bogus cast. Anyway, I pulled, but I really wish somebody had thought through those cases. Somebody who knows the code better than I do (maybe there is an error check later for "if (info->name && !info->address)", but I didn't see one in a quick grep). Linus