From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753805Ab0IQUhc (ORCPT ); Fri, 17 Sep 2010 16:37:32 -0400 Received: from www.tglx.de ([62.245.132.106]:35463 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753034Ab0IQUhb (ORCPT ); Fri, 17 Sep 2010 16:37:31 -0400 Date: Fri, 17 Sep 2010 22:37:26 +0200 (CEST) From: Thomas Gleixner To: "Eric W. Biederman" cc: Greg Kroah-Hartman , "Hans J. Koch" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] uio: Statically allocate uio_class and use class .dev_attrs. In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Sep 2010, Eric W. Biederman wrote: > > Instead of adding uio class attributes manually after the uio device has > been created and we have sent a uevent to userspace, use the class > attribute mechanism. This removes races and makes the code simpler. > > At the same time don't bother to dynamically allocate a struct class for > uio, just declare one statically. Less code is needed and it is easier > to set the class parameters.tune the class > > Signed-off-by: Eric W. Biederman Reviewed-by: Thomas Gleixner