From: Len Brown <lenb@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
x86@kernel.org
Subject: Re: [PATCH RESEND] tools: add power/x86/x86_energy_perf_policy to program MSR_IA32_ENERGY_PERF_BIAS
Date: Mon, 22 Nov 2010 23:48:26 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1011222343140.19247@x980> (raw)
In-Reply-To: <20101122203359.GD21836@basil.fritz.box>
On Mon, 22 Nov 2010, Andi Kleen wrote:
> On Mon, Nov 22, 2010 at 03:13:24PM -0500, Len Brown wrote:
> > Per the comments from Andrew and others, the concept of a
> > "full tools build" doesn't actually exit (yet).
> >
> > So I guess the only assurance that somebody not on x86 would run
> > make in this directory this utility lives in tools/power/x86/
> >
> > Note that there are other utilities under tools
> > which have no Makefile at all...
>
> I suspect this will need to be fixed at some point.
>
> e.g. kernel rpms probably don't want to hard code all of this
> but just call some standard make file target. And the kernel
> eventually needs a make install_user or similar.
I agree, but I don't volunteer to set up such
a build system as part of this particular patch.
As I mentioned, supplying any Makefile is
a step better than some of the peers...
> > I'm not inclined to bother, as the use-case for this utility
> > is to be invoked by another program, and the options available
>
> What other program?
>
> I could well imagine administrators sticking this
> into their boot.locals to set the policy they want.
right, and that would be a program.
It is unlikely that users are going to be typing this
command, except into an admin script.
> > In the highly unlikely scenario that somebody uses
> > the -r option to excerise the read-only code,
> > and simultaneously invokes and completes a cpu hot remove
>
> FWIW there are setups where core offlining can happen
> automatically in response to an error.
Understood. I think it is fine if this utility
simply exits if that error occurs while it is running.
(turbostat, OTOH, may be long running, and it treats
vanishing processors as a recoverable error)
thanks,
-Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-11-23 4:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 21:05 RFC: /sys/power/policy_preference Len Brown
2010-06-17 6:03 ` [linux-pm] " Igor.Stoppa
2010-06-17 19:00 ` Len Brown
2010-06-17 16:14 ` Victor Lowther
2010-06-17 19:02 ` Len Brown
2010-06-17 22:23 ` Victor Lowther
2010-06-18 5:56 ` Len Brown
2010-06-18 11:55 ` Victor Lowther
2010-06-19 15:17 ` Vaidyanathan Srinivasan
2010-06-19 19:04 ` Rafael J. Wysocki
2010-06-17 20:48 ` Mike Chan
2010-06-18 6:25 ` Len Brown
2010-06-21 20:10 ` [linux-pm] " Dipankar Sarma
2010-09-28 16:17 ` x86_energy_perf_policy.c Len Brown
2010-10-23 4:40 ` [PATCH] tools: add x86_energy_perf_policy to program MSR_IA32_ENERGY_PERF_BIAS Len Brown
2010-10-27 3:23 ` Andrew Morton
2010-10-27 6:01 ` Ingo Molnar
2010-10-27 11:43 ` Arnaldo Carvalho de Melo
2010-11-15 16:07 ` [PATCH RESEND] tools: add power/x86/x86_energy_perf_policy " Len Brown
2010-11-17 11:35 ` Andi Kleen
2010-11-22 20:13 ` Len Brown
2010-11-22 20:33 ` Andi Kleen
2010-11-23 4:48 ` Len Brown [this message]
2010-11-24 5:31 ` [PATCH v2] tools: create power/x86/x86_energy_perf_policy Len Brown
2010-11-25 5:52 ` Chen Gong
2010-11-25 8:59 ` Chen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1011222343140.19247@x980 \
--to=lenb@kernel.org \
--cc=andi@firstfloor.org \
--cc=gregkh@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).