From: Julian Anastasov <ja@ssi.bg>
To: Simon Horman <horms@verge.net.au>
Cc: Sasha Levin <levinsasha928@gmail.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
wensong@linux-vs.org, kaber@trash.net, davem@davemloft.net,
davej@redhat.com, netdev@vger.kernel.org,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered
Date: Fri, 13 Apr 2012 11:35:55 +0300 (EEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1204131134500.1778@ja.ssi.bg> (raw)
In-Reply-To: <20120413062250.GA6163@verge.net.au>
Hello,
On Fri, 13 Apr 2012, Simon Horman wrote:
> On Fri, Apr 13, 2012 at 01:11:50PM +0900, Simon Horman wrote:
> > On Fri, Apr 13, 2012 at 02:54:13AM +0200, Sasha Levin wrote:
> > > On Thu, Apr 12, 2012 at 1:46 AM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > >> If you return here, I think you'll leave things in inconsistent state,
> > > >> ie. the tcp protocol is registered. You have to unregister it before
> > > >> leaving.
> > >
> > > I thought that the cleanup callback is getting called for failed init
> > > calls, if that's not the case then we can probably call it ourselves
> > > if any of these failed.
> >
> > Good point. In any case, I think that I have found a new problem.
>
> [sni@]
>
> I have confirmed that the cleanup code is called on error, so I think that
> your existing patch is fine.
>
> Acked-by: Simon Horman <horms@verge.net.au>
>
> Pablo, please consider taking this change. The other problem I raised,
> though related, can be handled separately as it won't occur if the
> ftp helper isn't initialised.
Simon, I'm sending 2 patches for this ftp problem
in separate thread. Please, test if the problem is solved.
Regards
--
Julian Anastasov <ja@ssi.bg>
next prev parent reply other threads:[~2012-04-13 8:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 23:24 [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered Sasha Levin
2012-04-05 23:19 ` Simon Horman
2012-04-06 9:07 ` Sasha Levin
2012-04-11 23:22 ` Pablo Neira Ayuso
2012-04-11 23:46 ` Pablo Neira Ayuso
2012-04-12 21:41 ` Simon Horman
2012-04-13 0:54 ` Sasha Levin
2012-04-13 4:11 ` Simon Horman
2012-04-13 6:22 ` Simon Horman
2012-04-13 8:35 ` Julian Anastasov [this message]
2012-04-13 8:03 ` Hans Schillstrom
2012-04-13 21:13 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1204131134500.1778@ja.ssi.bg \
--to=ja@ssi.bg \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=kaber@trash.net \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).