From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752606Ab2DCIVH (ORCPT ); Tue, 3 Apr 2012 04:21:07 -0400 Received: from www.linutronix.de ([62.245.132.108]:53161 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239Ab2DCIVE (ORCPT ); Tue, 3 Apr 2012 04:21:04 -0400 Date: Tue, 3 Apr 2012 10:20:58 +0200 (CEST) From: Thomas Gleixner To: Benjamin Herrenschmidt cc: Russell King - ARM Linux , Grant Likely , Andreas Schwab , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Milton Miller , Rob Herring , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead In-Reply-To: <1333406005.30734.61.camel@pasglop> Message-ID: References: <1329383368-12122-1-git-send-email-grant.likely@secretlab.ca> <1329383368-12122-7-git-send-email-grant.likely@secretlab.ca> <20120402202848.1EB833E02A7@localhost> <20120402215524.GM24211@n2100.arm.linux.org.uk> <1333406005.30734.61.camel@pasglop> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Apr 2012, Benjamin Herrenschmidt wrote: > On Mon, 2012-04-02 at 22:55 +0100, Russell King - ARM Linux wrote: > > Well, presumably someone is calling irq_set_irq_type() asking explicitly > > for IRQ_TYPE_NONE. The code will now (as it always used to before David's > > change) do exactly what you ask this to: it will ask the type to be set > > to none. > > > > If you don't want to set the type to none, don't call the interface asking > > for that to happen. > > I think part of the idea with NONE is to use it as "reset that interrupt > to the "default" setting, whatever that means ... Well, the ship side set_type function could simply leave it alone and not touch the thing at all. That's how the core code did until we discovered that we broke Russells toys that way. Thanks, tglx