From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751904Ab2GOJvh (ORCPT <rfc822;w@1wt.eu>);
	Sun, 15 Jul 2012 05:51:37 -0400
Received: from www.linutronix.de ([62.245.132.108]:49657 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751394Ab2GOJv3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 15 Jul 2012 05:51:29 -0400
Date: Sun, 15 Jul 2012 11:51:22 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Mike Galbraith <mgalbraith@novell.com>
cc: Jan Kara <jack@suse.cz>, Jeff Moyer <jmoyer@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, linux-fsdevel@vger.kernel.org,
        Tejun Heo <tj@kernel.org>, Jens Axboe <jaxboe@fusionio.com>,
        mgalbraith@suse.com
Subject: Re: Deadlocks due to per-process plugging
In-Reply-To: <1342343673.28142.2.camel@marge.simpson.net>
Message-ID: <alpine.LFD.2.02.1207151150150.32033@ionos>
References: <20120711133735.GA8122@quack.suse.cz>  <x49ehoii8ps.fsf@segfault.boston.devel.redhat.com>  <20120711201601.GB9779@quack.suse.cz>  <alpine.LFD.2.02.1207121552111.32033@ionos>  <20120713123318.GB20361@quack.suse.cz>  <alpine.LFD.2.02.1207131444490.32033@ionos>
  <20120713144622.GB28715@quack.suse.cz>  <alpine.LFD.2.02.1207151057010.32033@ionos> <1342343673.28142.2.camel@marge.simpson.net>
User-Agent: Alpine 2.02 (LFD 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 15 Jul 2012, Mike Galbraith wrote:

> On Sun, 2012-07-15 at 10:59 +0200, Thomas Gleixner wrote: 
> > On Fri, 13 Jul 2012, Jan Kara wrote:
> > > On Fri 13-07-12 16:25:05, Thomas Gleixner wrote:
> > > > So the patch below should allow the unplug to take place when blocked
> > > > on mutexes etc.
> > >   Thanks for the patch! Mike will give it some testing.
> > 
> > I just found out that this patch will explode nicely when the unplug
> > code runs into a contended lock. Then we try to block on that lock and
> > make the rtmutex code unhappy as we are already blocked on something
> > else.
> 
> Kinda like so?  My x3550 M3 just exploded.  Aw poo. 

Yep. Would have surprised me if it never triggered.

> > So no, it's not a solution to the problem. Sigh.
> > 
> > Can you figure out on which lock the stuck thread which did not unplug
> > due to tsk_is_pi_blocked was blocked?
> 
> I'll take a peek.

Thanks!